feat: Add Playwright output folder to .gitignore

[fel1x-developer]

During sv create, when playwright and storybook is added to the new project, .gitignore should include

# Playwright
playwright-report

# Storybook
storybook-static

as these are output/build folders.

[manuel3108]

What did you change after scaffolding the project to make those tools generate files in those output folders? Just tried running storybook and playwright on a newly created project, and those folders were not created.

[fel1x-developer]

What did you change after scaffolding the project to make those tools generate files in those output folders? Just tried running storybook and playwright on a newly created project, and those folders were not created.

For storybook-static, run bun run build-storybook
playwright-report is created after you finish running bun run test:e2e

[manuel3108]

For storybook-static, run bun run build-storybook

Now i understand. Actually, we are only executing the storybook cli for the storybook add-on:

cli/packages/addons/storybook/index.ts

Line 9 in d1f4432

await sv.execute(['storybook@latest', 'init', '--skip-install', '--no-dev'], 'inherit');

@JReinhold is this maybe something that could be added to the storybook cli? We could technically also add it here if that causes trouble on your side.

playwright-report is created after you finish running bun run test:e2e

That's not happening for me on a freshly created project. Need to add that I'm running it with pnpm but that shouldn't make any difference. For me it's generating a test-results folder, but that one is already correctly added to the .gitignore

[fel1x-developer]

test-results folder is created when playwright is taking a screenshot and fails.

[manuel3108]

@JReinhold Do you think it would be viable that the storybook cli adds storybook-static to .gitignore.

Doing the same for playwright would be in our hands, obviously.

[JReinhold]

@manuel3108 thank you, we should have done this ages ago.

storybookjs/storybook#31201

Will take some time to be released because we're doing hard work on the upcoming major version. 🙂

[manuel3108]

thank you, we should have done this ages ago.

storybookjs/storybook#31201

Thanks!

Only the playwright thing remaining now.

[jycouet]

Just tested and test-results is in .gitignore now.
Code here: https://github.com/sveltejs/cli/blob/main/packages/addons/playwright/index.ts#L27-L31

I guess that this issue can be closed.