Skip to content

Commit 9686d8a

Browse files
authored
Merge pull request #15 from swift-server/jo/hb2-beta
Remove the 'HB' prefix
2 parents 8007a5f + 14bdd5a commit 9686d8a

File tree

4 files changed

+27
-27
lines changed

4 files changed

+27
-27
lines changed

Package.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ let package = Package(
1313
],
1414
dependencies: [
1515
.package(url: "https://github.com/apple/swift-openapi-runtime.git", from: "1.0.0"),
16-
.package(url: "https://github.com/hummingbird-project/hummingbird.git", from: "2.0.0-alpha.2"),
16+
.package(url: "https://github.com/hummingbird-project/hummingbird.git", from: "2.0.0-beta.1"),
1717
],
1818
targets: [
1919
.target(
@@ -27,7 +27,7 @@ let package = Package(
2727
name: "OpenAPIHummingbirdTests",
2828
dependencies: [
2929
"OpenAPIHummingbird",
30-
.product(name: "HummingbirdXCT", package: "hummingbird"),
30+
.product(name: "HummingbirdTesting", package: "hummingbird"),
3131
]
3232
),
3333
]

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ Hummingbird transport for [OpenAPI generator](https://github.com/apple/swift-ope
44

55
```swift
66
// Create your router.
7-
let router = HBRouter()
7+
let router = Router()
88

99
// Create an instance of your handler type that conforms the generated protocol
1010
// defining your service API.
@@ -15,7 +15,7 @@ let api = MyServiceAPIImpl()
1515
try api.registerHandlers(on: router)
1616

1717
// Create the application and run as you would normally.
18-
let app = HBApplication(router: router)
18+
let app = Application(router: router)
1919
try await app.runService()
2020
```
2121

Sources/OpenAPIHummingbird/OpenAPITransport.swift

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import Hummingbird
1818
import NIOHTTP1
1919
import OpenAPIRuntime
2020

21-
extension HBRouter: ServerTransport {
21+
extension Router: ServerTransport {
2222
/// Registers an HTTP operation handler at the provided path and method.
2323
/// - Parameters:
2424
/// - handler: A handler to be invoked when an HTTP request is received.
@@ -40,14 +40,14 @@ extension HBRouter: ServerTransport {
4040
let (openAPIRequest, openAPIRequestBody) = try request.makeOpenAPIRequest(context: context)
4141
let openAPIRequestMetadata = context.makeOpenAPIRequestMetadata()
4242
let (openAPIResponse, openAPIResponseBody) = try await handler(openAPIRequest, openAPIRequestBody, openAPIRequestMetadata)
43-
return HBResponse(openAPIResponse, body: openAPIResponseBody)
43+
return Response(openAPIResponse, body: openAPIResponseBody)
4444
}
4545
}
4646
}
4747

48-
extension HBRequest {
49-
/// Construct ``OpenAPIRuntime.Request`` from Hummingbird ``HBRequest``
50-
func makeOpenAPIRequest<Context: HBBaseRequestContext>(context: Context) throws -> (HTTPRequest, HTTPBody?) {
48+
extension Request {
49+
/// Construct ``OpenAPIRuntime.Request`` from Hummingbird ``Request``
50+
func makeOpenAPIRequest<Context: BaseRequestContext>(context: Context) throws -> (HTTPRequest, HTTPBody?) {
5151
let request = self.head
5252
// extract length from content-length header
5353
let length = if let contentLengthHeader = self.headers[.contentLength], let contentLength = Int(contentLengthHeader) {
@@ -64,8 +64,8 @@ extension HBRequest {
6464
}
6565
}
6666

67-
extension HBBaseRequestContext {
68-
/// Construct ``OpenAPIRuntime.ServerRequestMetadata`` from Hummingbird ``HBRequest``
67+
extension BaseRequestContext {
68+
/// Construct ``OpenAPIRuntime.ServerRequestMetadata`` from Hummingbird ``Request``
6969
func makeOpenAPIRequestMetadata() -> ServerRequestMetadata {
7070
let keyAndValues = self.parameters.map { (key: String($0.0), value: $0.1) }
7171
let openAPIParameters = [String: Substring](keyAndValues) { first, _ in first }
@@ -75,9 +75,9 @@ extension HBBaseRequestContext {
7575
}
7676
}
7777

78-
extension HBResponse {
78+
extension Response {
7979
init(_ response: HTTPResponse, body: HTTPBody?) {
80-
let responseBody: HBResponseBody
80+
let responseBody: ResponseBody
8181
if let body = body {
8282
let bufferSequence = body.map { ByteBuffer(bytes: $0)}
8383
if case .known(let length) = body.length {

Tests/OpenAPIHummingbirdTests/OpenAPITransportTests.swift

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
import HTTPTypes
1616
import Hummingbird
1717
import HummingbirdCore
18-
import HummingbirdXCT
18+
import HummingbirdTesting
1919
import NIOCore
2020
import NIOHTTP1
2121
import OpenAPIRuntime
@@ -31,9 +31,9 @@ extension HTTPField.Name {
3131

3232
final class HBOpenAPITransportTests: XCTestCase {
3333
func test_requestConversion() async throws {
34-
let router = HBRouter()
34+
let router = Router()
3535

36-
router.post("/hello/:name") { hbRequest, context -> HBResponse in
36+
router.post("/hello/:name") { hbRequest, context -> Response in
3737
// Hijack the request handler to test the request-conversion functions.
3838
let expectedRequest = HTTPRequest(
3939
method: .post,
@@ -60,15 +60,15 @@ final class HBOpenAPITransportTests: XCTestCase {
6060
XCTAssertEqual(collectedBody, [UInt8]("👋".utf8))
6161
XCTAssertEqual(context.makeOpenAPIRequestMetadata(), expectedRequestMetadata)
6262

63-
// Use the response-conversion to create the HBRequest for returning.
63+
// Use the response-conversion to create the Request for returning.
6464
let response = HTTPResponse(status: .created, headerFields: [.xMumble: "mumble"])
65-
return HBResponse(response, body: .init([UInt8]("👋".utf8)))
65+
return Response(response, body: .init([UInt8]("👋".utf8)))
6666
}
6767

68-
let app = HBApplication(responder: router.buildResponder())
68+
let app = Application(responder: router.buildResponder())
6969

7070
try await app.test(.live) { client in
71-
try await client.XCTExecute(
71+
try await client.execute(
7272
uri: "/hello/Maria?greeting=Howdy",
7373
method: .post,
7474
headers: [
@@ -86,11 +86,11 @@ final class HBOpenAPITransportTests: XCTestCase {
8686
}
8787

8888
func test_largeBody() async throws {
89-
let router = HBRouter()
89+
let router = Router()
9090
let bytes = (0..<1_000_000).map { _ in UInt8.random(in: 0...255)}
9191
let byteBuffer = ByteBuffer(bytes: bytes)
9292

93-
router.post("/hello/:name") { hbRequest, context -> HBResponse in
93+
router.post("/hello/:name") { hbRequest, context -> Response in
9494
// Hijack the request handler to test the request-conversion functions.
9595
let expectedRequest = HTTPRequest(
9696
method: .post,
@@ -109,12 +109,12 @@ final class HBOpenAPITransportTests: XCTestCase {
109109
XCTAssertEqual(request, expectedRequest)
110110
XCTAssertEqual(context.makeOpenAPIRequestMetadata(), expectedRequestMetadata)
111111

112-
// Use the response-conversion to create the HBRequest for returning.
112+
// Use the response-conversion to create the Request for returning.
113113
let response = HTTPResponse(status: .ok)
114-
return HBResponse(response, body: body)
114+
return Response(response, body: body)
115115
}
116116

117-
let app = HBApplication(
117+
let app = Application(
118118
router: router,
119119
server: .http1(
120120
additionalChannelHandlers: [
@@ -124,12 +124,12 @@ final class HBOpenAPITransportTests: XCTestCase {
124124
)
125125

126126
try await app.test(.live) { client in
127-
try await client.XCTExecute(
127+
try await client.execute(
128128
uri: "/hello/Maria?greeting=Howdy",
129129
method: .post,
130130
body: byteBuffer
131131
) { hbResponse in
132-
// Check the HBResponse (created from the Response) is what meets expectations.
132+
// Check the Response (created from the Response) is what meets expectations.
133133
XCTAssertEqual(hbResponse.status, .ok)
134134
XCTAssertEqual(byteBuffer, hbResponse.body)
135135
}

0 commit comments

Comments
 (0)