Skip to content

[Icons] Website's search seems to be broken #2826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
CyrilKrylatov opened this issue Jun 6, 2025 · 2 comments · Fixed by #2829
Closed

[Icons] Website's search seems to be broken #2826

CyrilKrylatov opened this issue Jun 6, 2025 · 2 comments · Fixed by #2829
Labels
Bug Bug Fix Icons

Comments

@CyrilKrylatov
Copy link
Contributor

Hello,

On https://ux.symfony.com/icons?query&set=mdi when I make a search like "b", I have the following JavaScript error:

Image

Image

How to reproduce:

Cheers!
@CyrilKrylatov CyrilKrylatov added the Bug Bug Fix label Jun 6, 2025
@carsonbot carsonbot added Icons Status: Needs Review Needs to be reviewed labels Jun 6, 2025
@smnandre
Copy link
Member

smnandre commented Jun 7, 2025

@CyrilKrylatov thank you for this report!

Do you remember "where" you got that URL from ?

It's a valid query string without a doubt, but i'm not sure "how" we generated it, and this would help understand why we were blind to this problem.

@smnandre smnandre removed the Status: Needs Review Needs to be reviewed label Jun 7, 2025
smnandre added a commit to smnandre/ux that referenced this issue Jun 8, 2025
@smnandre
[LiveComponent] Fix query string decoding with no =
cf4db16 
The root cause of symfony#2826 is in fact a bug  in LiveComponent ... that i'm very surprised no one already experienced oO

In url_utils: fromQueryString missed a nullcheck. Triggering a TypeError.

`
?foo&bar=
`
@smnandre smnandre mentioned this issue Jun 8, 2025
Merged
@Kocal Kocal closed this as completed in c4de247 Jun 8, 2025
@CyrilKrylatov
Copy link
Contributor Author

LGTM, thanks guys! Have a nice day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Bug Fix Icons
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[LiveComponent] Fix query string decoding with no = smnandre/ux
3 participants
@CyrilKrylatov @smnandre @carsonbot