Skip to content

Commit 3e58822

Browse files
authored
Build cli improvements (#44)
* Remove jscs, time-grunt, and grunt-bump * Update write method of Reporter to static * Rename test files * Rename files and switch to chai over should * Add nyc file to git ignore * Update travis config for npm scripts * Remove grunt files * Update format of lint issue logging * Update output format * Add npm scripts, bump version * Delete extra whitespace * Remove jsonlint * Remove require helper * Update ESLint config * Override class-method-use-this rule * Resolve ESLint issues * Resolve ESLint issue * Resolve ESLint issues * Remove unused var * Fix typo that was causing a reference error * Update changelog * Add missing dependency
1 parent 398c332 commit 3e58822

File tree

111 files changed

+664
-936
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

111 files changed

+664
-936
lines changed

.gitignore

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,3 +68,14 @@ node_modules
6868
####################################
6969
####################################
7070
mocha.json
71+
72+
73+
74+
75+
####################################
76+
####################################
77+
### nyc
78+
####################################
79+
####################################
80+
.nyc_output/
81+
coverage/

.jscsrc

Lines changed: 0 additions & 99 deletions
This file was deleted.

.travis.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@ cache:
2121
- node_modules
2222

2323
before_script:
24-
- npm install -g grunt-cli
2524
- npm prune
2625

2726
script:
28-
- grunt
29-
- grunt testcoverage
27+
- npm run lint
28+
- npm test
29+
- npm run coverage

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,12 @@ This project adheres to [Semantic Versioning](http://semver.org/).
1111

1212
### Removed
1313

14+
## [2.6.0] - 2017-07-30
15+
### Changed
16+
- Bumped dependencies
17+
- Converted grunt tasks to npm scripts
18+
- Update cli output format for cleaner output
19+
1420
## [2.5.0] - 2017-06-11
1521
### Changed
1622
@chr1shaefn3r enhanced the following rules so they no longer require a leading equals sign

CONTRIBUTING.md

Lines changed: 18 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,6 @@
99

1010
## Install project dependencies
1111

12-
### Global Node Module(s)
13-
14-
* [Grunt CLI](https://github.com/gruntjs/grunt-cli) - `npm install grunt-cli -g`
15-
1612
### Code
1713

1814
* Fork and clone the npm-package-json-lint repo
@@ -27,44 +23,46 @@ This installs dependencies from `package.json`.
2723

2824
Run `node src/cli.js`
2925

30-
## Code guidelines
26+
## npm scripts
3127

32-
### JS
28+
`npm run lint`
3329

34-
npm-package-json-lint utilizes both ESLint and JSCS to enforce JavaScript standards. Please see the `.eslintrc.json` file for ESLint config and `.jscsrc` for JSCS config.
30+
This will:
3531

36-
* [grunt-eslint](https://github.com/sindresorhus/grunt-eslint)
37-
* [grunt-jscs](https://github.com/jscs-dev/grunt-jscs)
32+
* run linters
3833

39-
#### JSON
34+
`npm test`
4035

41-
npm-package-json-lint utilizes JSON Lint to ensure JSON files are valid.
36+
This will:
4237

43-
* [grunt-jsonlint](https://github.com/brandonramirez/grunt-jsonlint)
38+
* run all of the mocha tests
4439

45-
#### Checking coding style
40+
## Code guidelines
41+
42+
### JS
4643

47-
Run `grunt lint` before committing to ensure your changes follow our coding standards.
44+
npm-package-json-lint utilizes ESLint to enforce JavaScript standards. Please see the `.eslintrc.json` file for ESLint config.
4845

46+
* [eslint](https://github.com/eslint/eslint)
4947

50-
### More info on Grunt
48+
#### Checking coding style
5149

52-
The configuration for Grunt tasks in this project are all in the `grunt/` folder in individual files. The Gruntfile loads in all the tasks from this folder.
50+
Run `npm run lint` before committing to ensure your changes follow our coding standards.
5351

5452
## Versioning
5553

56-
Please use the following grunt commands to increment the package's version numbers
54+
Please use the following commands to increment the package's version numbers
5755
EX: Assume current version is 0.0.1
5856

59-
`grunt bump:patch`
57+
`npm version patch --no-git-tag-version`
6058

6159
If you run this command the version will increase the patch number (ie 0.0.2)
6260

63-
`grunt bump:minor`
61+
`npm version minor --no-git-tag-version`
6462

6563
If you run this command the version will increase the minor number (ie 0.1.0)
6664

67-
`grunt bump:major`
65+
`npm version major --no-git-tag-version`
6866

6967
If you run this command the version will increase the major number (ie 1.0.0)
7068

Gruntfile.js

Lines changed: 0 additions & 42 deletions
This file was deleted.

grunt/bump.js

Lines changed: 0 additions & 15 deletions
This file was deleted.

grunt/clean.js

Lines changed: 0 additions & 11 deletions
This file was deleted.

grunt/coverage-check.js

Lines changed: 0 additions & 20 deletions
This file was deleted.

grunt/env.js

Lines changed: 0 additions & 10 deletions
This file was deleted.

0 commit comments

Comments
 (0)