From 5ce98bee74b19e336aac34dbc0129d6d4f45b7e0 Mon Sep 17 00:00:00 2001 From: Kevin Woo <3469532+kevinawoo@users.noreply.github.com> Date: Thu, 17 Apr 2025 17:17:39 -0700 Subject: [PATCH 1/3] add missing import for Go's auto tuner --- docs/develop/worker-performance.mdx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/develop/worker-performance.mdx b/docs/develop/worker-performance.mdx index 134650275f..b060efd7a3 100644 --- a/docs/develop/worker-performance.mdx +++ b/docs/develop/worker-performance.mdx @@ -274,6 +274,8 @@ These examples focus on Activities and Local Activities, since Workflow Tasks no ### Go SDK ```go +import "go.temporal.io/sdk/contrib/resourcetuner" + // Using the ResourceBasedTuner in worker options tuner, err := resourcetuner.NewResourceBasedTuner(resourcetuner.ResourceBasedTunerOptions{ TargetMem: 0.8, From 4be570a292221aa6261ff687ab1c3a68daa1e8dd Mon Sep 17 00:00:00 2001 From: Kevin Woo <3469532+kevinawoo@users.noreply.github.com> Date: Fri, 18 Apr 2025 12:05:00 -0700 Subject: [PATCH 2/3] use exported defaults --- docs/develop/worker-performance.mdx | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/docs/develop/worker-performance.mdx b/docs/develop/worker-performance.mdx index b060efd7a3..8036f89dcf 100644 --- a/docs/develop/worker-performance.mdx +++ b/docs/develop/worker-performance.mdx @@ -287,23 +287,24 @@ if err != nil { workerOptions := worker.Options{ Tuner: tuner } -// Combining different types -options := DefaultResourceControllerOptions() + +// Customize the tuner +options := resourcetuner.DefaultResourceControllerOptions() options.MemTargetPercent = 0.8 options.CpuTargetPercent = 0.9 -controller := NewResourceController(options) +controller := resourcetuner.NewResourceController(options) wfSS, err := worker.NewFixedSizeSlotSupplier(10) if err != nil { return err } -actSS := &ResourceBasedSlotSupplier{controller: controller, - options: defaultActivityResourceBasedSlotSupplierOptions()} -laSS := &ResourceBasedSlotSupplier{controller: controller, - options: defaultActivityResourceBasedSlotSupplierOptions()} + +actSS := resourcetuner.NewResourceBasedSlotSupplier(controller, resourcetuner.DefaultActivityResourceBasedSlotSupplierOptions()} +laSS := resourcetuner.NewResourceBasedSlotSupplier(controller, resourcetuner.DefaultActivityResourceBasedSlotSupplierOptions()} nexusSS, err := worker.NewFixedSizeSlotSupplier(10) if err != nil { return err } + compositeTuner, err := worker.NewCompositeTuner(worker.CompositeTunerOptions{ WorkflowSlotSupplier: wfSS, ActivitySlotSupplier: actSS, From b92d40663a51401d528d438db8f00a3640873951 Mon Sep 17 00:00:00 2001 From: Kevin Woo <3469532+kevinawoo@users.noreply.github.com> Date: Mon, 21 Apr 2025 12:53:15 -0700 Subject: [PATCH 3/3] fix syntax typos --- docs/develop/worker-performance.mdx | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/docs/develop/worker-performance.mdx b/docs/develop/worker-performance.mdx index 8036f89dcf..e01e8ba034 100644 --- a/docs/develop/worker-performance.mdx +++ b/docs/develop/worker-performance.mdx @@ -285,7 +285,7 @@ if err != nil { return err } workerOptions := worker.Options{ - Tuner: tuner + Tuner: tuner, } // Customize the tuner @@ -298,24 +298,24 @@ if err != nil { return err } -actSS := resourcetuner.NewResourceBasedSlotSupplier(controller, resourcetuner.DefaultActivityResourceBasedSlotSupplierOptions()} -laSS := resourcetuner.NewResourceBasedSlotSupplier(controller, resourcetuner.DefaultActivityResourceBasedSlotSupplierOptions()} +actSS, err := resourcetuner.NewResourceBasedSlotSupplier(controller, resourcetuner.DefaultActivityResourceBasedSlotSupplierOptions()) +laSS, err := resourcetuner.NewResourceBasedSlotSupplier(controller, resourcetuner.DefaultActivityResourceBasedSlotSupplierOptions()) nexusSS, err := worker.NewFixedSizeSlotSupplier(10) if err != nil { return err } compositeTuner, err := worker.NewCompositeTuner(worker.CompositeTunerOptions{ - WorkflowSlotSupplier: wfSS, - ActivitySlotSupplier: actSS, - LocalActivitySlotSupplier: laSS, - NexusSlotSupplier: nexusSS, + WorkflowSlotSupplier: wfSS, + ActivitySlotSupplier: actSS, + LocalActivitySlotSupplier: laSS, + NexusSlotSupplier: nexusSS, }) if err != nil { return err } workerOptions := worker.Options{ - Tuner: compositeTuner + Tuner: compositeTuner, } ```