test: add more updates.checkAllUpdates tests

Author: ewanharris

src/updates/index.ts

@@ -33,7 +33,8 @@ async function checkAllUpdates(supportedVersions?: SupportedVersions, useAppcToo
 
 	const updates = await Promise.all(updateChecks);
 
-	return updates.filter(update => update && update.hasUpdate);
+	// Remove anything that doesn't require an update and then sort the array by running priority
+	return updates.filter(update => update && update.hasUpdate).sort((curr: UpdateInfo, prev: UpdateInfo) => curr.priority - prev.priority);
 }
 
 export {

tests/fixtures/network/network-mocks.ts

@@ -19,27 +19,30 @@ export function mockAppcCoreRequest (version: string): void {
 		});
 }
 
+// we use nock.reply and fs.readFileSync instead of nock.replyWithFile to ensure that the files are
+// read before setting up any fs mocks. If we used nock.replyWitFile we get errors
+
 export function mockSDKRequest (): void {
 	nock('https://appc-mobilesdk-server.s3-us-west-2.amazonaws.com')
 		.get('/releases.json')
-		.replyWithFile(200, path.join(__dirname, 'sdk-response.json'));
+		.reply(200, fs.readFileSync(path.join(__dirname, 'sdk-response.json'), 'utf8'));
 
 }
 
 export function mockNpmRequest (): void {
 	nock('https://registry.npmjs.org')
 		.get('/appcelerator/latest')
-		.replyWithFile(200, path.join(__dirname, 'appcelerator-npm-response.json'))
+		.reply(200, fs.readFileSync(path.join(__dirname, 'appcelerator-npm-response.json'), 'utf8'))
 		.get('/alloy/latest')
-		.replyWithFile(200, path.join(__dirname, 'alloy-npm-response.json'))
+		.reply(200, fs.readFileSync(path.join(__dirname, 'alloy-npm-response.json'), 'utf8'))
 		.get('/titanium/latest')
-		.replyWithFile(200, path.join(__dirname, 'titanium-npm-response.json'));
+		.reply(200, fs.readFileSync(path.join(__dirname, 'titanium-npm-response.json'), 'utf8'));
 }
 
 export function mockNodeRequest(): void {
 	nock('https://nodejs.org')
 		.get('/download/release/index.json')
-		.replyWithFile(200, path.join(__dirname, 'node-response.json'))
+		.reply(200, fs.readFileSync(path.join(__dirname, 'node-response.json'), 'utf8'))
 		.get('/dist/v1.2.3/node-v1.2.3.pkg')
 		.reply(200, () => {
 			return fs.createReadStream(path.join(__dirname, 'node-installer.pkg'));

tests/updates-test.ts

@@ -422,7 +422,7 @@ describe('updates', () => {
 	});
 
 	describe('checkforUpdates', () => {
-		it('useAppcTooling false', async () => {
+		it('useAppcTooling false no updates', async () => {
 			const stub = global.sandbox.stub(util, 'exec');
 			mockNodeRequest();
 			mockSDKRequest();
@@ -435,5 +435,63 @@ describe('updates', () => {
 			const updates = await checkAllUpdates({}, false);
 			expect(updates.length).to.equal(0);
 		});
+
+		it('useAppcTooling false with updates', async () => {
+			const stub = global.sandbox.stub(util, 'exec');
+			mockNodeRequest();
+			mockSDKRequest();
+			mockNpmRequest();
+			mockSdk('8.0.0');
+			mockNode(stub, '12.18.1');
+			mockNpmCli(stub, 'alloy', '1.15.3');
+			mockNpmCli(stub, 'titanium', '5.3.0');
+
+			const updates = await checkAllUpdates({}, false);
+			expect(updates.length).to.equal(2);
+
+			expect(updates[0].productName).to.equal('Node.js');
+			expect(updates[0].currentVersion).to.equal('12.18.1');
+			expect(updates[0].latestVersion).to.equal('12.18.2');
+
+			expect(updates[1].productName).to.equal('Alloy');
+			expect(updates[1].currentVersion).to.equal('1.15.3');
+			expect(updates[1].latestVersion).to.equal('1.15.4');
+		});
+
+		it('useAppcTooling true no updates', async () => {
+			const stub = global.sandbox.stub(util, 'exec');
+			mockNodeRequest();
+			mockSDKRequest();
+			mockNpmRequest();
+			mockSdk('8.0.0');
+			mockNode(stub, '12.18.2');
+			mockAppcCoreRequest('6.6.6');
+			mockAppcCli(stub, '6.6.6', '4.2.13', true);
+
+			const updates = await checkAllUpdates({}, true);
+			expect(updates.length).to.equal(0);
+		});
+
+		it('useAppcTooling true with updates', async () => {
+			const stub = global.sandbox.stub(util, 'exec');
+			mockNodeRequest();
+			mockSDKRequest();
+			mockNpmRequest();
+			mockSdk('8.0.0');
+			mockNode(stub, '12.18.1');
+			mockAppcCoreRequest('6.6.6');
+			mockAppcCli(stub, '6.6.6', '4.2.12', true);
+
+			const updates = await checkAllUpdates({}, true);
+			expect(updates.length).to.equal(2);
+
+			expect(updates[0].productName).to.equal('Node.js');
+			expect(updates[0].currentVersion).to.equal('12.18.1');
+			expect(updates[0].latestVersion).to.equal('12.18.2');
+
+			expect(updates[1].productName).to.equal('Appcelerator CLI (npm)');
+			expect(updates[1].currentVersion).to.equal('4.2.12');
+			expect(updates[1].latestVersion).to.equal('4.2.13');
+		});
 	});
 });