-
Notifications
You must be signed in to change notification settings - Fork 15
[WIP]: add async support to tls_fetcher/proxy and qos #517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
required for any async work
allows for tokio-vsock usage
minimum required bumped due to tokio and tokio-vsock
this includes: - AsyncStream [qos_core] - AsyncListener [qos_core] - AsyncRequestProcessor [qos_core] - AsyncProxyConnection [qos_net] - AsyncProxy [qos_net] - AsyncProxyStream [qos_net]
@Turnalek two immediate observations:
|
Thank for taking a look! I didn't realize PRs in this repo go to ready state by default and only flagged to WIP afterwards. I suspect I'll first get an overall functional PR and then split it into sections to get merged piece by piece. For the Rust upgrade, it was a quick and dirty way to fix our currently broken main. Specifically, if in main you do There is however a second reason which is to say we need to upgrade to 1.83 as minimum due to We should def. clean this up and if things need to be completely locked down it should be done using the So TLDR: this is a WIP POC PR to see if things will be functional the way we hope with this change. After all roadblocks are confirmed fix[able] I will split into smaller PRs. |
This wouldn't be the typical workflow here, since we're very selective in QOS to avoid unnecessary dependency changes. We want to do some level of security review on the Rust code of dependencies, which quickly becomes very time-consuming when making broad changes. The fact that cargo selects dependency updates even if they violate the specified project Rust version (machine readable in It's clear that if |
superseded by #524 |
Summary & Motivation (Problem vs. Solution)
This PR attempts to add async support to our Vsock/UnixSock and TcpStream abstractions to allow async calls in the IO bound tls_fetcher accross the board.
How I Tested These Changes
TODO
Pre merge check list