task: disallow blocking in LocalSet::{poll,drop}
#7372
+118
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
added
A-tokio
Darksonn
changed the title
LocalSet::{poll,drop}
mox692
reviewed
May 30, 2025
| let reset = CONTEXT.with(|c| { | ||
| let reset = CONTEXT.try_with(|c| { |
There was a problem hiding this comment.
It might be worth aligning here too?
tokio/tokio/src/runtime/context/blocking.rs
Line 109 in ab8d7b8
I think drop still gets panic if CONTEXT.try_with returns Err when constructing a DisallowBlockInPlaceGuard.
There was a problem hiding this comment.
If the first try_with fails, then the guard stores false so the if makes us skip that CONTEXT.with call.
There was a problem hiding this comment.
I missed that if condition, never mind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #7368