From 339c8ab1a8020cdc8940be4672d4922ab489943f Mon Sep 17 00:00:00 2001 From: Hentry Martin Date: Mon, 16 Jun 2025 18:49:38 +0530 Subject: [PATCH 1/7] debug apply copilot --- .circleci/config.yml | 2 +- src/routes/copilotOpportunityApply/create.js | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index d4c591c5..235c89cf 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -149,7 +149,7 @@ workflows: context : org-global filters: branches: - only: ['develop', 'migration-setup', 'pm-1173_1'] + only: ['develop', 'migration-setup', 'pm-1175_2'] - deployProd: context : org-global filters: diff --git a/src/routes/copilotOpportunityApply/create.js b/src/routes/copilotOpportunityApply/create.js index 829eec36..0cedb55b 100644 --- a/src/routes/copilotOpportunityApply/create.js +++ b/src/routes/copilotOpportunityApply/create.js @@ -71,10 +71,16 @@ module.exports = [ const pmRole = await util.getRolesByRoleName(USER_ROLE.PROJECT_MANAGER, req.log, req.id); const { subjects = [] } = await util.getRoleInfo(pmRole[0], req.log, req.id); + req.log.debug(subjects, 'all manager subjects'); + const creator = await util.getMemberDetailsByUserIds([opportunity.userId], req.log, req.id); + + req.log.debug(subjects, 'creator'); + const listOfSubjects = subjects; if (creator) { const isCreatorPartofSubjects = subjects.find(item => item.email.toLowerCase() === creator[0].email.toLowerCase()); + req.log.debug(isCreatorPartofSubjects, 'isCreatorPartofSubjects'); if (!isCreatorPartofSubjects) { listOfSubjects.push({ email: creator[0].email, @@ -82,6 +88,8 @@ module.exports = [ }); } } + + req.log.debug(listOfSubjects, 'final list of subjects'); const emailEventType = CONNECT_NOTIFICATION_EVENT.EXTERNAL_ACTION_EMAIL; const copilotPortalUrl = config.get('copilotPortalUrl'); From 9be8c5ff85f6344c2c87ca27bb4be97082e6af1f Mon Sep 17 00:00:00 2001 From: Hentry Martin Date: Mon, 16 Jun 2025 19:14:03 +0530 Subject: [PATCH 2/7] debug apply copilot --- src/routes/copilotOpportunityApply/create.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/routes/copilotOpportunityApply/create.js b/src/routes/copilotOpportunityApply/create.js index 0cedb55b..c1650516 100644 --- a/src/routes/copilotOpportunityApply/create.js +++ b/src/routes/copilotOpportunityApply/create.js @@ -75,7 +75,7 @@ module.exports = [ const creator = await util.getMemberDetailsByUserIds([opportunity.userId], req.log, req.id); - req.log.debug(subjects, 'creator'); + req.log.debug(creator, 'creator'); const listOfSubjects = subjects; if (creator) { From d95af0dd02a280c6ddfa227f199fdb2fa9f0138e Mon Sep 17 00:00:00 2001 From: Hentry Martin Date: Mon, 16 Jun 2025 20:48:28 +0530 Subject: [PATCH 3/7] fix: use correct field --- src/routes/copilotOpportunityApply/create.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/routes/copilotOpportunityApply/create.js b/src/routes/copilotOpportunityApply/create.js index c1650516..cbe02e4d 100644 --- a/src/routes/copilotOpportunityApply/create.js +++ b/src/routes/copilotOpportunityApply/create.js @@ -73,7 +73,7 @@ module.exports = [ req.log.debug(subjects, 'all manager subjects'); - const creator = await util.getMemberDetailsByUserIds([opportunity.userId], req.log, req.id); + const creator = await util.getMemberDetailsByUserIds([opportunity.createdBy], req.log, req.id); req.log.debug(creator, 'creator'); From 126ea0b9590bb50650b25506ba32994a518a680e Mon Sep 17 00:00:00 2001 From: Hentry Martin Date: Mon, 16 Jun 2025 20:48:46 +0530 Subject: [PATCH 4/7] fix: use correct field --- src/routes/copilotOpportunityApply/create.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/routes/copilotOpportunityApply/create.js b/src/routes/copilotOpportunityApply/create.js index cbe02e4d..cee025fc 100644 --- a/src/routes/copilotOpportunityApply/create.js +++ b/src/routes/copilotOpportunityApply/create.js @@ -75,7 +75,7 @@ module.exports = [ const creator = await util.getMemberDetailsByUserIds([opportunity.createdBy], req.log, req.id); - req.log.debug(creator, 'creator'); + req.log.debug(creator, 'creator', opportunity.createdBy); const listOfSubjects = subjects; if (creator) { From 3875c3e5cbce7ab73fc2d5c7ec8e50053784af7c Mon Sep 17 00:00:00 2001 From: Hentry Martin Date: Mon, 16 Jun 2025 21:10:18 +0530 Subject: [PATCH 5/7] fix: lowercase null exception --- src/routes/copilotOpportunityApply/create.js | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/routes/copilotOpportunityApply/create.js b/src/routes/copilotOpportunityApply/create.js index cee025fc..b62e9bf7 100644 --- a/src/routes/copilotOpportunityApply/create.js +++ b/src/routes/copilotOpportunityApply/create.js @@ -74,12 +74,17 @@ module.exports = [ req.log.debug(subjects, 'all manager subjects'); const creator = await util.getMemberDetailsByUserIds([opportunity.createdBy], req.log, req.id); - req.log.debug(creator, 'creator', opportunity.createdBy); const listOfSubjects = subjects; - if (creator) { - const isCreatorPartofSubjects = subjects.find(item => item.email.toLowerCase() === creator[0].email.toLowerCase()); + if (creator && creator[0] && creator[0].email) { + const isCreatorPartofSubjects = subjects.find(item => { + if (!item.email) { + return false; + } + + return item.email.toLowerCase() === creator[0].email.toLowerCase(); + }); req.log.debug(isCreatorPartofSubjects, 'isCreatorPartofSubjects'); if (!isCreatorPartofSubjects) { listOfSubjects.push({ From 92ee79e2fff32fdc3a0e226a578ff8b648d21e5e Mon Sep 17 00:00:00 2001 From: Hentry Martin Date: Mon, 16 Jun 2025 22:15:46 +0530 Subject: [PATCH 6/7] removed debug logs --- src/routes/copilotOpportunityApply/create.js | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/routes/copilotOpportunityApply/create.js b/src/routes/copilotOpportunityApply/create.js index b62e9bf7..4bfbea9f 100644 --- a/src/routes/copilotOpportunityApply/create.js +++ b/src/routes/copilotOpportunityApply/create.js @@ -71,10 +71,7 @@ module.exports = [ const pmRole = await util.getRolesByRoleName(USER_ROLE.PROJECT_MANAGER, req.log, req.id); const { subjects = [] } = await util.getRoleInfo(pmRole[0], req.log, req.id); - req.log.debug(subjects, 'all manager subjects'); - const creator = await util.getMemberDetailsByUserIds([opportunity.createdBy], req.log, req.id); - req.log.debug(creator, 'creator', opportunity.createdBy); const listOfSubjects = subjects; if (creator && creator[0] && creator[0].email) { @@ -85,7 +82,6 @@ module.exports = [ return item.email.toLowerCase() === creator[0].email.toLowerCase(); }); - req.log.debug(isCreatorPartofSubjects, 'isCreatorPartofSubjects'); if (!isCreatorPartofSubjects) { listOfSubjects.push({ email: creator[0].email, @@ -93,8 +89,6 @@ module.exports = [ }); } } - - req.log.debug(listOfSubjects, 'final list of subjects'); const emailEventType = CONNECT_NOTIFICATION_EVENT.EXTERNAL_ACTION_EMAIL; const copilotPortalUrl = config.get('copilotPortalUrl'); From 70e8e405437f1f4935db2ece53949ddf73979a7c Mon Sep 17 00:00:00 2001 From: Hentry Martin Date: Mon, 16 Jun 2025 22:16:07 +0530 Subject: [PATCH 7/7] removed circle ci configs --- .circleci/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 235c89cf..1acd4a4c 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -149,7 +149,7 @@ workflows: context : org-global filters: branches: - only: ['develop', 'migration-setup', 'pm-1175_2'] + only: ['develop', 'migration-setup'] - deployProd: context : org-global filters: