Merge pull request #371 from uhafner/package-private-tests

Package private tests

Author: uhafner

etc/pmd-configuration.xml

@@ -13,6 +13,7 @@
     <exclude name="UnusedImports"/>
     <exclude name="GuardLogStatement"/>
     <exclude name="AccessorMethodGeneration"/>
+    <exclude name="JUnit5TestShouldBePackagePrivate"/>
     <exclude name="UnusedPrivateMethod"/>
   </rule>
   <rule ref="category/java/codestyle.xml">

src/test/java/edu/hm/hafner/util/ArchitectureRules.java

@@ -40,13 +40,13 @@ private ArchitectureRules() {
                     .and().doNotHaveModifier(JavaModifier.ABSTRACT)
                     .should().bePublic();
 
-    /** Junit 5 test methods should not be public. */
-    public static final ArchRule NO_PUBLIC_TEST_METHODS =
+    /** Junit 5 test methods should be package private. */
+    public static final ArchRule ONLY_PACKAGE_PRIVATE_TEST_METHODS =
             methods().that().areAnnotatedWith(Test.class)
                     .or().areAnnotatedWith(ParameterizedTest.class)
                     .and().areDeclaredInClassesThat()
                     .haveSimpleNameEndingWith("Test")
-                    .should().notBePublic();
+                    .should().bePackagePrivate();
 
     /** ArchUnit tests should not be public. */
     public static final ArchRule NO_PUBLIC_ARCHITECTURE_TESTS =

src/test/java/edu/hm/hafner/util/ArchitectureTest.java

@@ -16,7 +16,7 @@ class ArchitectureTest {
     static final ArchRule NO_PUBLIC_TEST_CLASSES = ArchitectureRules.NO_PUBLIC_TEST_CLASSES;
 
     @ArchTest
-    static final ArchRule NO_PUBLIC_TEST_METHODS = ArchitectureRules.NO_PUBLIC_TEST_METHODS;
+    static final ArchRule ONLY_PACKAGE_PRIVATE_TEST_METHODS = ArchitectureRules.ONLY_PACKAGE_PRIVATE_TEST_METHODS;
 
     @ArchTest
     static final ArchRule NO_PUBLIC_ARCHITECTURE_TESTS = ArchitectureRules.NO_PUBLIC_ARCHITECTURE_TESTS;