Fixing conditions (#18)

* fix: assignment compatiblity issues

* chore: documentation

Author: Abdul Wahid

CHANGELOG.md

@@ -5,7 +5,13 @@ All notable changes to this project will be documented in this file.
 <a name="unreleased"></a>
 ## [Unreleased]
 
-- Upgrade to 5.x compatibility + update examples/variables
+- fix: assignment compatiblity issues
+
+
+<a name="3.3.0"></a>
+## [3.3.0] - 2023-07-27
+
+- Upgrade to 5.x compatibility + update examples/variables ([#17](https://github.com/umotif-public/terraform-aws-rds-aurora/issues/17))
 
 
 <a name="3.2.1"></a>
@@ -109,7 +115,8 @@ All notable changes to this project will be documented in this file.
 - Initial commit
 
 
-[Unreleased]: https://github.com/umotif-public/terraform-aws-rds-aurora/compare/3.2.1...HEAD
+[Unreleased]: https://github.com/umotif-public/terraform-aws-rds-aurora/compare/3.3.0...HEAD
+[3.3.0]: https://github.com/umotif-public/terraform-aws-rds-aurora/compare/3.2.1...3.3.0
 [3.2.1]: https://github.com/umotif-public/terraform-aws-rds-aurora/compare/3.2.0...3.2.1
 [3.2.0]: https://github.com/umotif-public/terraform-aws-rds-aurora/compare/3.1.0...3.2.0
 [3.1.0]: https://github.com/umotif-public/terraform-aws-rds-aurora/compare/3.0.0...3.1.0

main.tf

@@ -128,7 +128,7 @@ resource "aws_rds_cluster" "main" {
 
   port                   = var.port == "" ? var.engine == "aurora-postgresql" ? "5432" : "3306" : var.port
   db_subnet_group_name   = var.db_subnet_group_name == "" ? aws_db_subnet_group.main[0].name : var.db_subnet_group_name
-  vpc_security_group_ids = compact(concat(aws_security_group.main[0].id, var.vpc_security_group_ids))
+  vpc_security_group_ids = compact(concat([aws_security_group.main[0].id], var.vpc_security_group_ids))
   storage_encrypted      = var.storage_encrypted
 
   db_cluster_parameter_group_name     = var.create_parameter_group ? aws_rds_cluster_parameter_group.main[0].id : var.db_cluster_parameter_group_name
@@ -298,7 +298,7 @@ resource "aws_rds_cluster_instance" "main" {
   preferred_maintenance_window = var.preferred_instance_maintenance_window
   apply_immediately            = var.apply_immediately
 
-  monitoring_role_arn             = var.create_monitoring_role ? aws_iam_role.rds_enhanced_monitoring[0].arn : var.monitoring_role_arn
+  monitoring_role_arn             = var.create_monitoring_role && var.monitoring_interval > 0 ? aws_iam_role.rds_enhanced_monitoring[0].arn : var.monitoring_role_arn
   monitoring_interval             = var.monitoring_interval
   auto_minor_version_upgrade      = var.auto_minor_version_upgrade
   performance_insights_enabled    = var.performance_insights_enabled