diff --git a/packages/app-layout/test/visual/fixed-height-styles.js b/packages/app-layout/test/visual/fixed-height-styles.js new file mode 100644 index 00000000000..6cdf3dc26fc --- /dev/null +++ b/packages/app-layout/test/visual/fixed-height-styles.js @@ -0,0 +1,12 @@ +import { css, registerStyles } from '@vaadin/vaadin-themable-mixin/vaadin-themable-mixin.js'; + +registerStyles( + 'vaadin-app-layout', + css` + :host, + :host([overlay]) [part='backdrop'], + [part='drawer'] { + height: inherit; + } + `, +); diff --git a/packages/app-layout/test/visual/lumo/app-layout.test.js b/packages/app-layout/test/visual/lumo/app-layout.test.js index 0ff4a9562a9..2921033cc31 100644 --- a/packages/app-layout/test/visual/lumo/app-layout.test.js +++ b/packages/app-layout/test/visual/lumo/app-layout.test.js @@ -1,5 +1,6 @@ import { fixtureSync } from '@vaadin/testing-helpers/dist/fixture.js'; import { visualDiff } from '@web/test-runner-visual-regression'; +import '../fixed-height-styles.js'; import '../../../theme/lumo/vaadin-app-layout.js'; import '../../../theme/lumo/vaadin-drawer-toggle.js'; @@ -8,7 +9,7 @@ describe('app-layout', () => { beforeEach(() => { div = document.createElement('div'); - div.style.height = '100%'; + div.style.height = '600px'; element = fixtureSync( ` diff --git a/packages/app-layout/test/visual/lumo/screenshots/app-layout/baseline/ltr-basic.png b/packages/app-layout/test/visual/lumo/screenshots/app-layout/baseline/ltr-basic.png index e87473380ac..89c5e88bf91 100644 Binary files a/packages/app-layout/test/visual/lumo/screenshots/app-layout/baseline/ltr-basic.png and b/packages/app-layout/test/visual/lumo/screenshots/app-layout/baseline/ltr-basic.png differ diff --git a/packages/app-layout/test/visual/lumo/screenshots/app-layout/baseline/ltr-overlay.png b/packages/app-layout/test/visual/lumo/screenshots/app-layout/baseline/ltr-overlay.png index 19f7eca5aad..ec54f3f0a75 100644 Binary files a/packages/app-layout/test/visual/lumo/screenshots/app-layout/baseline/ltr-overlay.png and b/packages/app-layout/test/visual/lumo/screenshots/app-layout/baseline/ltr-overlay.png differ diff --git a/packages/app-layout/test/visual/lumo/screenshots/app-layout/baseline/ltr-primary-drawer-overlay-opened.png b/packages/app-layout/test/visual/lumo/screenshots/app-layout/baseline/ltr-primary-drawer-overlay-opened.png index 38fc01c8515..d60d6647692 100644 Binary files a/packages/app-layout/test/visual/lumo/screenshots/app-layout/baseline/ltr-primary-drawer-overlay-opened.png and b/packages/app-layout/test/visual/lumo/screenshots/app-layout/baseline/ltr-primary-drawer-overlay-opened.png differ diff --git a/packages/app-layout/test/visual/lumo/screenshots/app-layout/baseline/ltr-primary-drawer.png b/packages/app-layout/test/visual/lumo/screenshots/app-layout/baseline/ltr-primary-drawer.png index e73aa77a4cc..89e52481ef0 100644 Binary files a/packages/app-layout/test/visual/lumo/screenshots/app-layout/baseline/ltr-primary-drawer.png and b/packages/app-layout/test/visual/lumo/screenshots/app-layout/baseline/ltr-primary-drawer.png differ diff --git a/packages/app-layout/test/visual/lumo/screenshots/app-layout/baseline/rtl-basic.png b/packages/app-layout/test/visual/lumo/screenshots/app-layout/baseline/rtl-basic.png index d7d7cbce635..152d16cae70 100644 Binary files a/packages/app-layout/test/visual/lumo/screenshots/app-layout/baseline/rtl-basic.png and b/packages/app-layout/test/visual/lumo/screenshots/app-layout/baseline/rtl-basic.png differ diff --git a/packages/app-layout/test/visual/lumo/screenshots/app-layout/baseline/rtl-overlay.png b/packages/app-layout/test/visual/lumo/screenshots/app-layout/baseline/rtl-overlay.png index 0293de9e21e..3f189b2d5b4 100644 Binary files a/packages/app-layout/test/visual/lumo/screenshots/app-layout/baseline/rtl-overlay.png and b/packages/app-layout/test/visual/lumo/screenshots/app-layout/baseline/rtl-overlay.png differ diff --git a/packages/app-layout/test/visual/lumo/screenshots/app-layout/baseline/rtl-primary-drawer-overlay-opened.png b/packages/app-layout/test/visual/lumo/screenshots/app-layout/baseline/rtl-primary-drawer-overlay-opened.png index 0b276e97880..cf87fb12b98 100644 Binary files a/packages/app-layout/test/visual/lumo/screenshots/app-layout/baseline/rtl-primary-drawer-overlay-opened.png and b/packages/app-layout/test/visual/lumo/screenshots/app-layout/baseline/rtl-primary-drawer-overlay-opened.png differ diff --git a/packages/app-layout/test/visual/lumo/screenshots/app-layout/baseline/rtl-primary-drawer.png b/packages/app-layout/test/visual/lumo/screenshots/app-layout/baseline/rtl-primary-drawer.png index 49c2aa05426..0ec8e4165c7 100644 Binary files a/packages/app-layout/test/visual/lumo/screenshots/app-layout/baseline/rtl-primary-drawer.png and b/packages/app-layout/test/visual/lumo/screenshots/app-layout/baseline/rtl-primary-drawer.png differ diff --git a/packages/app-layout/test/visual/material/app-layout.test.js b/packages/app-layout/test/visual/material/app-layout.test.js index 48e775f90b6..adfccf65e44 100644 --- a/packages/app-layout/test/visual/material/app-layout.test.js +++ b/packages/app-layout/test/visual/material/app-layout.test.js @@ -1,5 +1,6 @@ import { fixtureSync } from '@vaadin/testing-helpers/dist/fixture.js'; import { visualDiff } from '@web/test-runner-visual-regression'; +import '../fixed-height-styles.js'; import '../../../theme/material/vaadin-app-layout.js'; import '../../../theme/material/vaadin-drawer-toggle.js'; @@ -8,7 +9,7 @@ describe('app-layout', () => { beforeEach(() => { div = document.createElement('div'); - div.style.height = '100%'; + div.style.height = '600px'; element = fixtureSync( ` diff --git a/packages/app-layout/test/visual/material/screenshots/app-layout/baseline/ltr-basic.png b/packages/app-layout/test/visual/material/screenshots/app-layout/baseline/ltr-basic.png index e21ef51391e..77cf1c4f41c 100644 Binary files a/packages/app-layout/test/visual/material/screenshots/app-layout/baseline/ltr-basic.png and b/packages/app-layout/test/visual/material/screenshots/app-layout/baseline/ltr-basic.png differ diff --git a/packages/app-layout/test/visual/material/screenshots/app-layout/baseline/ltr-overlay.png b/packages/app-layout/test/visual/material/screenshots/app-layout/baseline/ltr-overlay.png index e3c4f613ee9..e8374449093 100644 Binary files a/packages/app-layout/test/visual/material/screenshots/app-layout/baseline/ltr-overlay.png and b/packages/app-layout/test/visual/material/screenshots/app-layout/baseline/ltr-overlay.png differ diff --git a/packages/app-layout/test/visual/material/screenshots/app-layout/baseline/ltr-primary-drawer-overlay-opened.png b/packages/app-layout/test/visual/material/screenshots/app-layout/baseline/ltr-primary-drawer-overlay-opened.png index ac5fd0bcf6b..74449f7b28c 100644 Binary files a/packages/app-layout/test/visual/material/screenshots/app-layout/baseline/ltr-primary-drawer-overlay-opened.png and b/packages/app-layout/test/visual/material/screenshots/app-layout/baseline/ltr-primary-drawer-overlay-opened.png differ diff --git a/packages/app-layout/test/visual/material/screenshots/app-layout/baseline/ltr-primary-drawer.png b/packages/app-layout/test/visual/material/screenshots/app-layout/baseline/ltr-primary-drawer.png index f5c4aa84027..d93dccb5af0 100644 Binary files a/packages/app-layout/test/visual/material/screenshots/app-layout/baseline/ltr-primary-drawer.png and b/packages/app-layout/test/visual/material/screenshots/app-layout/baseline/ltr-primary-drawer.png differ diff --git a/packages/app-layout/test/visual/material/screenshots/app-layout/baseline/rtl-basic.png b/packages/app-layout/test/visual/material/screenshots/app-layout/baseline/rtl-basic.png index 3ba070cfbaf..e9870e6599f 100644 Binary files a/packages/app-layout/test/visual/material/screenshots/app-layout/baseline/rtl-basic.png and b/packages/app-layout/test/visual/material/screenshots/app-layout/baseline/rtl-basic.png differ diff --git a/packages/app-layout/test/visual/material/screenshots/app-layout/baseline/rtl-overlay.png b/packages/app-layout/test/visual/material/screenshots/app-layout/baseline/rtl-overlay.png index 88d6080a157..88aa80dddfc 100644 Binary files a/packages/app-layout/test/visual/material/screenshots/app-layout/baseline/rtl-overlay.png and b/packages/app-layout/test/visual/material/screenshots/app-layout/baseline/rtl-overlay.png differ diff --git a/packages/app-layout/test/visual/material/screenshots/app-layout/baseline/rtl-primary-drawer-overlay-opened.png b/packages/app-layout/test/visual/material/screenshots/app-layout/baseline/rtl-primary-drawer-overlay-opened.png index c01d77519bf..2ce3e875c09 100644 Binary files a/packages/app-layout/test/visual/material/screenshots/app-layout/baseline/rtl-primary-drawer-overlay-opened.png and b/packages/app-layout/test/visual/material/screenshots/app-layout/baseline/rtl-primary-drawer-overlay-opened.png differ diff --git a/packages/app-layout/test/visual/material/screenshots/app-layout/baseline/rtl-primary-drawer.png b/packages/app-layout/test/visual/material/screenshots/app-layout/baseline/rtl-primary-drawer.png index bab29477f26..9d0dda1f953 100644 Binary files a/packages/app-layout/test/visual/material/screenshots/app-layout/baseline/rtl-primary-drawer.png and b/packages/app-layout/test/visual/material/screenshots/app-layout/baseline/rtl-primary-drawer.png differ