Skip to content

Class reagents don't end up in the correct category #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Szalor opened this issue Apr 10, 2025 · 10 comments
Open

Class reagents don't end up in the correct category #137

Szalor opened this issue Apr 10, 2025 · 10 comments
Assignees
Labels
bug Something isn't working

Comments

@Szalor
Copy link

Szalor commented Apr 10, 2025

Describe the bug

With bags being open, i've bought 2 extra stacks of Demonic Figurines and Infernal Stones, they ended up in Class Items group instead of Class Reagents.

Once the bags are closed and then reopened, everything is in right places.

To reproduce

  1. Open bags.
  2. Buy Infernal Stone.

Expected behavior

All the reagents go in the Class Reagents group directly when acquired.

Screenshots

Image
Image

Environment

Bagshui Version: 1.5.2
Game Version: 1.17.2 7207 Apr 01 2025

Addons

SuperWoW: 1.5

Enabled:

  • [SUPERWOW] Cursive 1.0
  • [K] LazyPig 6.0.5
  • Atlas TurtleWOW 1.13.8
  • AtlasLoot TurtleWOW 3.0.9
  • AtlasQuest TurtleWOW 4.1.7
  • aux
  • Bagshui 1.5.2
  • BetterCharacterStats 1.13.0 1.13.0
  • Bloodring Filter 1
  • Bongos 6.10.29
  • Bongos_ActionBar 6.10.25
  • Bongos_Options
  • cdframes
  • ColorPickerPlus -Ace2- 1.12
  • DruidManaBar
  • Enchantrix 3.6.1 (Platypus)
  • EnhTooltip 3.8.0 (Kangaroo)
  • Inspector 1.0.0
  • ItemRack
  • Mik's Scrolling Battle Text 4.43
  • Mik's Scrolling Battle Text Options 4.43
  • MobResistAndDmg 1.2
  • MoveAnything!
  • MPOWA -Shino- 1.6.0
  • Nampower Settings
  • Omni Cooldown Count
  • Postal Returned -Ace2- 1.1.1
  • PvP Warning 1.0.0
  • Roid Macros
  • ShardCap
  • shootyepgp 3.60
  • SimpleActionSets 0.47b
  • Stubby 3.8.0 (Kangaroo)
  • SuperAPI -balake-
  • Tmog -Spit- 1.8
  • TrainerSkills 2.1.7
  • Turtle HC Filter 1.0.0
  • UndressButton
  • unitscanTurtle 1.0.4+
  • Consumes Manager [Horyoshi] 2.1.0
  • pfQuest GIT
  • pfQuest [TurtleWoW DB] GIT
  • pfUI 5.4.17
  • pfUI [TurtleWoW skins] 1.0.0
  • pfUI [Elite Overlay] 1.0
  • ShaguChat 1.0
  • PizzaWorldBuffs 1.5.1
  • TW Threatmeter v1.2.3 1.2.3
  • LockPort 2.0.3
  • Pepopo Big Wigs 30110 Turtle-WoW 2.0.0
  • ShaguDPS 2.1
Disabled:
  • C'Thun Warner 1.06

Additional context

No response

@Szalor Szalor added the bug Something isn't working label Apr 10, 2025
@veechs
Copy link
Owner

veechs commented Apr 10, 2025

That’s exactly how Bagshui is supposed to behave when your bags are open and why the Organize button (the little broom) lights up. This is done because otherwise items would constantly be shifting around whenever anything changes, which can lead to misclicks and other confusion. (I did have instant organization enabled early in development and it never felt right.)

Hopefully this explains things!

@veechs
Copy link
Owner

veechs commented Apr 10, 2025

By the way, you can set a key binding for the Organize button if you find that faster than clicking.

@Szalor
Copy link
Author

Szalor commented Apr 10, 2025

I would expect the reagents to go to "empty slots" whenever i buy them, but they go in a different group altogether, that's why it seemed weird to me. I get that new items would go in empty slots, that makes sense, but not in this case, somehow.

@veechs
Copy link
Owner

veechs commented Apr 10, 2025

Ah, I think I see the confusion now! Bagshui doesn’t place items when you right-click something from the Bank, vendor, etc.; it just asks WoW to perform the action and then WoW puts the item wherever. What you’re seeing is a peek behind the curtain where WoW is placing items in whatever empty bag slot it deems best. Since Bagshui is a virtual overlay on top of your inventory, it doesn’t care which specific bag slot something is in, and things get “moved” to their correct visual positions on the next reorganization.

In theory it would be possible to intercept the vendor right-click action and actually place items in the “correct” empty slots, but that’s not high on my priority list. 🙂

@Szalor
Copy link
Author

Szalor commented Apr 10, 2025

I think i'm starting to understand. Since in this very particular case, the "by default" wow's placement of infernal reagents & stuff goes to soul bags instead of normal inventory, the first thing by default that it finds is the "class items" group?

@veechs
Copy link
Owner

veechs commented Apr 10, 2025

Now I’m starting to wonder now if I might have misinterpreted your initial comment and screenshots. 🤔 Everything I said is still true, but it’s possible you’re experiencing some unexpected behavior.

I’ll do some testing later, and if you’re able to get a video of what you’re seeing, that would be hugely helpful.

@veechs
Copy link
Owner

veechs commented Apr 11, 2025

I tested and the only way I could produce anything similar was to first put a Spellstone and a Firestone in my bags, destroy them while at the vendor, and the buy the reagents. So I’m hoping you’ll if be able to get a recording of what you’re seeing.

@Szalor
Copy link
Author

Szalor commented Apr 11, 2025

Here's an example where i buy (or buy back) some demonic figurines. They end up in the class items group instead of class reagents.
https://gyazo.com/ce4e486667d0059cfd74d59c7c271544

@veechs
Copy link
Owner

veechs commented Apr 11, 2025

Thank you, now I fully understand what you’re seeing (and it’s absolutely not something I expect to be happening). So I can be sure I have the right setup to try and reproduce the issue, could you also provide the Bagshui.lua file from WTF\Account<AccountName>\SavedVariables?

@Szalor
Copy link
Author

Szalor commented Apr 14, 2025

Sorry i didn't check your answers on this issue, here's the file you asked:

Bagshui.lua.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants