Skip to content

Lag in raid groups #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
veechs opened this issue Apr 27, 2025 · 4 comments
Open

Lag in raid groups #153

veechs opened this issue Apr 27, 2025 · 4 comments
Assignees
@veechs
Labels
bug Something isn't working

Comments

@veechs
Copy link
Owner

veechs commented Apr 27, 2025 •
edited
Loading

Describe the bug

In some situations (primarily in raid groups, both in and out of combat), Bagshui can cause lag. This probably started with 1.5.

To reproduce

Enable Bagshui while in a raid group.

Expected behavior

No lag, obvs.

Screenshots

No response

Environment

Bagshui 1.5+

Additional context

No response
@veechs veechs added the bug Something isn't working label Apr 27, 2025
@veechs veechs self-assigned this Apr 27, 2025
@veechs veechs pinned this issue Apr 27, 2025
@veechs
Copy link
Owner Author

veechs commented Apr 27, 2025

Preliminary work has been done on the inventory-event-tweaking branch. This seems to improve things for some people, but more improvements are probably needed.

@veechs
Copy link
Owner Author

veechs commented Apr 27, 2025

Make some more updates to inventory-event-tweaking -- now all events are deferred while in combat, so long as no Bagshui inventory windows are open. (The previous change only deferred some update processes, not the events themselves, so this is a more aggressive approach.)

⚠️ Barely tested, so breakage is possible.

@veechs
Copy link
Owner Author

veechs commented Apr 30, 2025 •
edited
Loading

Further updates to the test branch allow debug data to be logged on demand.

/bs debug log saves any debug messages to the debugLog property of WTF\Account<AccountName>\SavedVariables\Bagshui.lua.

Debug output to chat is also available via /bs debug on. The two commands are independent, so use both to see and save messages.

Debug logging automatically turns off at logout or reload. To disable manually: /bs debug nolog (and /bs debug off for chat messages).

veechs added a commit that referenced this issue May 18, 2025
@veechs
Fix over-eager Character-related event consumption
8bcdef4 
This might be the final fix for #153. 🤞
- Check arg1 for UNIT_INVENTORY_CHANGED so we ignore it for party/raid members.
- Delay all updates by 1 second to allow multiple events to coalesce.
- Remove UPDATE_INVENTORY_ALERTS -- this is about durability, not equipped gear changes.
@veechs veechs changed the title Lag in combat Lag in raid groups May 19, 2025
@veechs veechs mentioned this issue May 19, 2025
Merged
@veechs
Copy link
Owner Author

veechs commented May 22, 2025

This is mostly resolved as of 1.5.10 with additional minor optimizations to come in a future release.

@veechs veechs unpinned this issue May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@veechs veechs

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

inventory-event-tweaking veechs/Bagshui
1 participant
@veechs