Highlight Changes should only be enabled for visible inventory windows

[ggb00]

Describe the bug

"Highlight Changes" button always shows as active, meaning that there are new items or changes to items in the inventory, but when clicked, it shows that there are no new/changed items.

To reproduce

1. Buy "Goblin Brainwashing Device"
2. Use it (i.e. add it to "Toys" tab)

Expected behavior

The button shouldn't always be active, but only when there's new/changed items.

Screenshots

Environment

Bagshui Version: 1.5.9
Game Version: 1.17.2 7207 Apr 01 2025

Addons

SuperWoW: 1.5

Enabled:

• [K] LazyPig 6.0.5
• Artisan -Spit- 2.1
• Atlas TurtleWOW 1.13.8
• AtlasLoot TurtleWOW 3.1.3
• AtlasQuest TurtleWOW 4.1.7
• aux
• Bagshui 1.5.9
• BananaBar Raid Symbols 1.6
• BetterCharacterStats 1.13.3 1.13.3
• Cartographer [TurtleWoW] -Ace2- 2.0.2
• Decursive 1.9.9
• Dhask's FlightMap v1.12-1
• Difficult Bulletin Board
• DisableEscape 1.0.0
• Gentle GC 1.0
• HealersMate 2.0.0-alpha5.1
• Mail
• MinimapButtonBag-TurtleWoW 0.508
• MoveAnything!
• Nampower Settings
• Outfitter
• ProcDoc 2.4.1
• RABuffs
• Rested XP
• SimpleActionSets 0.47b
• SuperAPI Castlib -balake-
• SuperAPI -balake-
• SuperIgnore 1.4.5
• UnitXP SP3 Lua Addon
• VCB -Shino- 3.0
• What's Training? Turtle 1.0.7
• pfQuest GIT
• pfQuest [Gatherer Icons] GIT
• pfQuest [TurtleWoW DB] GIT
• PizzaWorldBuffs 1.6.3
• TW Threatmeter v1.2.3 1.2.3
• Pepopo Big Wigs 30110 Turtle-WoW 2.0.0
• ShaguDPS 3.0.1
• ShaguTweaks GIT
• ShaguTweaks-mods GIT

Disabled:

• ChatBar 2.5
• pfDebug 0.1

Additional context

No response

[veechs]

Thank you for the report! Does the issue persist after closing and reopening your bags? And if so, does it continue after a reload/logout?

[ggb00]

Thank you for your work! And yes, the issue persists after closing and reopening bags, restarting the game and even after clearing WDB files.

Additionally, it only affects the character I found the bug on.

[veechs]

Would you be able to upload the Bagshui.lua file from WTF\Account\<AccountName>\SavedVariables? I don't have access to the Goblin Brainwashing Device, but this might help me investigate the problem.

[ggb00]

Sure, here's the link. I uploaded it to another site, because github doesn't allow upload of .lua files.

[ggb00]

This issue has been fixed as of version 1.5.10, though I'm not sure how or if that would happen again if Goblin Brainwashing Device is purchased again.

[veechs]

I finally had a chance to look at your Bagshui SavedVariables, and it was showing an item to highlight because the Karazhan Crypt Key was new in your Keyring, and the Highlight Changes button in Bags applies to both Bags and Keyring. Maybe I need to change it so it only becomes enabled for Keyring items if the Keyring window is actually visible, because otherwise it's obviously confusing. 🙂