Skip to content

Commit eb3ef22

Browse files
committed
Fixed DinD integration test
1 parent 8125e20 commit eb3ef22

File tree

4 files changed

+10
-4
lines changed

4 files changed

+10
-4
lines changed

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,4 @@ jobs:
1717
- name: Build integration test image
1818
run: docker build -t compose-test -f test.Dockerfile .
1919
- name: Run integration test
20-
run: docker run --rm -v /var/run/docker.sock:/var/run/docker.sock:ro -t compose-test
20+
run: docker run --rm --add-host=host.docker.internal:host-gateway -v /var/run/docker.sock:/var/run/docker.sock:ro -t compose-test

test.Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,4 +29,5 @@ RUN \
2929
WORKDIR /test
3030
ADD ./test/ /test/
3131
COPY --from=builder /go/src/app/main /test/docker-compose-watcher
32+
EXPOSE 1883
3233
CMD ["/test/run-test.sh"]

test/mqtt.Dockerfile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
FROM eclipse-mosquitto:2
2+
ADD mosquitto.conf /mosquitto/config/
3+
ADD mqpass /mosquitto/config/

test/run-test.sh

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,9 @@ function checkMqttLogContains() {
3333
function runComposeUpdateAndLog() {
3434
sh -c "docker exec compose-test-mqtt mosquitto_sub -h 127.0.0.1 -u compose-updater -P ${MQTT_PASS} -t 'composeupdater/#' -v" &> ${WORKDIR}/mqtt.log &
3535
sleep 1
36-
ONCE=1 PRINT_SETTINGS=1 MQTT_BROKER=tcp://127.0.0.1:1883 MQTT_USERNAME=compose-updater MQTT_PASSWORD=${MQTT_PASS} ${WORKDIR}/docker-compose-watcher &> ${WORKDIR}/test.log
36+
ONCE=1 PRINT_SETTINGS=1 MQTT_BROKER=tcp://host.docker.internal:1883 MQTT_USERNAME=compose-updater MQTT_PASSWORD=${MQTT_PASS} ${WORKDIR}/docker-compose-watcher &> ${WORKDIR}/test.log
3737
sleep 1
38-
kill $(ps | grep "docker exec compose-test-mqtt mosquitto_sub" | grep -v "grep" | cut -d' ' -f 1)
38+
kill $(ps | grep "docker exec compose-test-mqtt mosquitto_sub" | grep -v "grep" | sed -e 's/^[[:space:]]*//' | cut -d' ' -f 1)
3939
echo "------------ Compose Updater Log ------------"
4040
cat ${WORKDIR}/test.log
4141
echo "----------------- MQTT Log ------------------"
@@ -148,6 +148,7 @@ mkdir -p ${WORKDIR} ${WORKDIR}/c1 ${WORKDIR}/c2 ${WORKDIR}/src
148148
cp ./test.Dockerfile ${WORKDIR}/Dockerfile
149149
cp ./mosquitto.conf ${WORKDIR}
150150
cp ./mqpass ${WORKDIR}
151+
cp ./mqtt.Dockerfile ${WORKDIR}
151152
PWD=$(echo ${WORKDIR} | sed 's_/_\\/_g')
152153
cat ./c1.yaml | sed "s/\${PWD}/${PWD}/g" > ${WORKDIR}/c1/compose1.yaml
153154
cat ./c2.yaml | sed "s/\${PWD}/${PWD}/g" > ${WORKDIR}/c2/docker-compose.yml
@@ -158,7 +159,8 @@ docker build -q --no-cache -t watcher-test-1 ${WORKDIR}
158159
docker build -q --no-cache -t watcher-test-2 ${WORKDIR}
159160

160161
echo "Starting MQTT broker..."
161-
docker run --rm -p 1883:1883 --name compose-test-mqtt -v ${WORKDIR}/mosquitto.conf:/mosquitto/config/mosquitto.conf:ro -v ${WORKDIR}/mqpass:/mosquitto/config/mqpass:ro -d eclipse-mosquitto:latest
162+
docker build -t compose-test-mqtt -f ${WORKDIR}/mqtt.Dockerfile ${WORKDIR}
163+
docker run --rm -p 1883:1883 --name compose-test-mqtt -d compose-test-mqtt
162164

163165
echo "Starting composition 1..."
164166
docker compose -f ${WORKDIR}/c1/compose1.yaml up -d --quiet-pull

0 commit comments

Comments
 (0)