Skip to content

Commit 43578bb

Browse files
committed
feat(timeline): display error/warning icons
1 parent db55bcd commit 43578bb

File tree

3 files changed

+35
-2
lines changed

3 files changed

+35
-2
lines changed

packages/app-frontend/src/features/timeline/TimelineEventInspector.vue

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,18 @@ export default {
5454
{{ inspectedEvent.title || 'Event' }}
5555
</span>
5656

57+
<VueIcon
58+
v-if="inspectedEvent.logType === 'error'"
59+
icon="error"
60+
class="w-4 h-4 text-red-500"
61+
/>
62+
63+
<VueIcon
64+
v-if="inspectedEvent.logType === 'warning'"
65+
icon="warning"
66+
class="w-4 h-4 text-yellow-500"
67+
/>
68+
5769
<span
5870
v-if="inspectedEvent.subtitle"
5971
class="opacity-75"

packages/app-frontend/src/features/timeline/TimelineEventListItem.vue

Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,27 @@ export default {
4949
'text-purple-600 dark:text-purple-400': !isInspected,
5050
}"
5151
>
52-
{{ event.title || 'Event' }}
52+
<span>{{ event.title || 'Event' }}</span>
53+
54+
<VueIcon
55+
v-if="event.logType === 'error'"
56+
icon="error"
57+
class="w-4 h-4 ml-1"
58+
:class="{
59+
'text-red-500': !isInspected,
60+
'text-white': isInspected
61+
}"
62+
/>
63+
64+
<VueIcon
65+
v-if="event.logType === 'warning'"
66+
icon="warning"
67+
class="w-4 h-4 ml-1"
68+
:class="{
69+
'text-yellow-500': !isInspected,
70+
'text-white': isInspected
71+
}"
72+
/>
5373
</span>
5474

5575
<span

packages/shell-dev-vue3/src/devtools-plugin/index.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,8 @@ export default {
203203
info: 'window.mouseup',
204204
x: event.clientX,
205205
y: event.clientY
206-
}
206+
},
207+
logType: event.clientX < 100 ? 'error' : event.clientY < 100 ? 'warning' : 'default'
207208
}
208209
})
209210
})

0 commit comments

Comments
 (0)