Don’t call libxml_disable_entity_loader() on recent libxml

Since libxml 2.9.0, entity substitution is disabled by default and can
only be enabled by passing LIBXML_NOENT with the parse call (e.g.
DOMDocument::loadHTML()). Since we don’t pass LIBXML_NOENT, it’s safe
for us to skip the libxml_disable_entity_loader() call on libxml
versions newer than that, which is good, because the function was
deprecated in PHP 8.

References: PHP.Watch [1] and PHP pull request #5867 [2]. (The function
documentation [3] doesn’t explain this very clearly, in my opinion.)

[1]: https://php.watch/versions/8.0/libxml_disable_entity_loader-deprecation
[2]: https://github.com/php/php-src/pull/5867/files
[3]: https://www.php.net/manual/en/function.libxml-disable-entity-loader.php

Author: lucaswerkmeister

src/Component.php

@@ -67,7 +67,9 @@ public function render( array $data ) {
 	 * @return DOMDocument
 	 */
 	private function parseHtml( $html ) {
-		$entityLoaderDisabled = libxml_disable_entity_loader( true );
+		if ( LIBXML_VERSION < 20900 ) {
+			$entityLoaderDisabled = libxml_disable_entity_loader( true );
+		}
 		$internalErrors = libxml_use_internal_errors( true );
 		$document = new DOMDocument( '1.0', 'UTF-8' );
 
@@ -84,7 +86,9 @@ private function parseHtml( $html ) {
 
 		// Restore previous state
 		libxml_use_internal_errors( $internalErrors );
-		libxml_disable_entity_loader( $entityLoaderDisabled );
+		if ( LIBXML_VERSION < 20900 ) {
+			libxml_disable_entity_loader( $entityLoaderDisabled );
+		}
 
 		foreach ( $errors as $error ) {
 			//TODO html5 tags can fail parsing