Dropdown: togglerClass gets removed by Nav

[Mister-42]

echo Nav::widget()
	->items(
	Dropdown::widget()
		->addTogglerClass('test-class')
		->items(
			DropdownItem::link('Item', '#'),
		)
	);

Expected:

<ul class="nav">
<li class="nav-item dropdown">
<a class="nav-link dropdown-toggle test-class" href="#" role="button" data-bs-toggle="dropdown" aria-expanded="false">Dropdown button</a>
<ul class="dropdown-menu">
<li>
<a class="dropdown-item" href="#">Item</a>
</li>
</ul>

Actual:

<ul class="nav">
<li class="nav-item dropdown">
<a class="nav-link dropdown-toggle" href="#" role="button" data-bs-toggle="dropdown" aria-expanded="false">Dropdown button</a>
<ul class="dropdown-menu">
<li>
<a class="dropdown-item" href="#">Item</a>
</li>
</ul>

---

This does work as expected:

echo Dropdown::widget()
	->addTogglerClass('test-class')
	->items(
		DropdownItem::link('Item', '#'),
	);

Result:

<div class="dropdown">
<button type="button" class="btn btn-secondary dropdown-toggle test-class" data-bs-toggle="dropdown" aria-expanded="false">Dropdown button</button>
<ul class="dropdown-menu">
<li>
<a class="dropdown-item" href="[#](https://test.mister42.eu/test/#)">Item</a>
</li>
</ul>
</div>

[Mister-42]

Same issue with addClass()

echo Nav::widget()
	->items(
	Dropdown::widget()
		->addClass('test-class1')
		->addTogglerClass('test-class2')
		->items(
			DropdownItem::link('Item', '#'),
		)
	);

<ul class="nav">
<li class="nav-item dropdown">
<a class="nav-link dropdown-toggle" href="#" role="button" data-bs-toggle="dropdown" aria-expanded="false">Dropdown button</a>
<ul class="dropdown-menu">
<li>
<a class="dropdown-item" href="#">Item</a>
</li>
</ul>

[terabytesoftw]

When we refactored bootstrap5 we decided to be strict about component toggles, but you can use your own toggle, but support could be added without any problem.

Do you have time to do a PR?

[vjik]

Seems, it needs to replace togglerClass() to addTogglerClass() here: https://github.com/yiisoft/bootstrap5/blob/ae4ac789fabf4d895f43f17523cb4d990aa8258c/src/Nav.php#L590C23-L590C35

[Mister-42]

I wish it was that simple. That would break a lot of things

There were 6 failures:

1) Yiisoft\Bootstrap5\Tests\NavBarTest::testRender
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
 <a class="nav-link" href="/link">Link</a>\n
 </li>\n
 <li class="nav-item dropdown">\n
-<a class="nav-link dropdown-toggle" href="#" role="button" data-bs-toggle="dropdown" aria-expanded="false">Dropdown</a>\n
+<a class="btn btn-secondary dropdown-toggle nav-link dropdown-toggle" href="#" role="button" data-bs-toggle="dropdown" aria-expanded="false">Dropdown</a>\n
 <ul class="dropdown-menu">\n
 <li>\n
 <a class="dropdown-item" href="/sub/action">Action</a>\n

bootstrap5/tests/Support/Assert.php:26
bootstrap5/tests/NavBarTest.php:922

2) Yiisoft\Bootstrap5\Tests\NavTest::testDropdownAndCurrentPath
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
 <a class="nav-link" href="/test">Active</a>\n
 </li>\n
 <li class="nav-item dropdown">\n
-<a class="nav-link dropdown-toggle" href="#" role="button" data-bs-toggle="dropdown" aria-expanded="false">Dropdown</a>\n
+<a class="btn btn-secondary dropdown-toggle nav-link dropdown-toggle" href="#" role="button" data-bs-toggle="dropdown" aria-expanded="false">Dropdown</a>\n
 <ul class="dropdown-menu">\n
 <li>\n
 <a class="dropdown-item" href="/test/link/action">Action</a>\n

bootstrap5/tests/Support/Assert.php:26
bootstrap5/tests/NavTest.php:402

3) Yiisoft\Bootstrap5\Tests\NavTest::testDropdownAndCurrentPathAndActivateItemsWithFalseValue
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
 <a class="nav-link" href="/test">Active</a>\n
 </li>\n
 <li class="nav-item dropdown">\n
-<a class="nav-link dropdown-toggle" href="#" role="button" data-bs-toggle="dropdown" aria-expanded="false">Dropdown</a>\n
+<a class="btn btn-secondary dropdown-toggle nav-link dropdown-toggle" href="#" role="button" data-bs-toggle="dropdown" aria-expanded="false">Dropdown</a>\n
 <ul class="dropdown-menu">\n
 <li>\n
 <a class="dropdown-item" href="/test/link/action">Action</a>\n

bootstrap5/tests/Support/Assert.php:26
bootstrap5/tests/NavTest.php:458

4) Yiisoft\Bootstrap5\Tests\NavTest::testDropdownExplicitActive
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
 <a class="nav-link" href="/test">Active</a>\n
 </li>\n
 <li class="nav-item dropdown">\n
-<a class="nav-link dropdown-toggle" href="#" role="button" data-bs-toggle="dropdown" aria-expanded="false">Dropdown</a>\n
+<a class="btn btn-secondary dropdown-toggle nav-link dropdown-toggle" href="#" role="button" data-bs-toggle="dropdown" aria-expanded="false">Dropdown</a>\n
 <ul class="dropdown-menu">\n
 <li>\n
 <a class="dropdown-item" href="/test/link/action">Action</a>\n

bootstrap5/tests/Support/Assert.php:26
bootstrap5/tests/NavTest.php:515

5) Yiisoft\Bootstrap5\Tests\NavTest::testPillsWithDropdown
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
 <a class="nav-link active" href="#" aria-current="page">Active</a>\n
 </li>\n
 <li class="nav-item dropdown">\n
-<a class="nav-link dropdown-toggle" href="#" role="button" data-bs-toggle="dropdown" aria-expanded="false">Dropdown</a>\n
+<a class="btn btn-secondary dropdown-toggle nav-link dropdown-toggle" href="#" role="button" data-bs-toggle="dropdown" aria-expanded="false">Dropdown</a>\n
 <ul class="dropdown-menu">\n
 <li>\n
 <a class="dropdown-item" href="#">Action</a>\n

bootstrap5/tests/Support/Assert.php:26
bootstrap5/tests/NavTest.php:947

6) Yiisoft\Bootstrap5\Tests\NavTest::testTabsWithDropdown
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
 <a class="nav-link active" href="#" aria-current="page">Active</a>\n
 </li>\n
 <li class="nav-item dropdown">\n
-<a class="nav-link dropdown-toggle" href="#" role="button" data-bs-toggle="dropdown" aria-expanded="false">Dropdown</a>\n
+<a class="btn btn-secondary dropdown-toggle nav-link dropdown-toggle" href="#" role="button" data-bs-toggle="dropdown" aria-expanded="false">Dropdown</a>\n
 <ul class="dropdown-menu">\n
 <li>\n
 <a class="dropdown-item" href="#">Action</a>\n

bootstrap5/tests/Support/Assert.php:26
bootstrap5/tests/NavTest.php:1263

FAILURES!
Tests: 648, Assertions: 1116, Failures: 6.

[terabytesoftw]

@Mister-42 #289 This should solve the problem.

[Mister-42]

@Mister-42 #289 This should solve the problem.

That's awesome. Thanks!
Works for addTogglerClass(), not yet for addClass()