PHP 8.3 support.

[terabytesoftw]

Hi, we should consider upgrading the PHP version in the master branch. Running PHPUnit 4 to accommodate new PHP versions has become quite cumbersome due to the need to patch PHPUnit, which sometimes leads to unexpected errors. By raising the minimum required PHP version to at least 8.1, in my opinion, we can update our packages without breaking backward compatibility. In my tests with branch 2.2, i found that PHP 8.3 is entirely compatible. Those who need to use versions older than 8.1 can continue using 2.0.49, as suggested by @rob006 #19831 (reply in thread).

This would, in some way, allow us to maintain the code more easily and address bugs more effectively.

Test php 8.3: #19953

@yiisoft/yii2, @yiisoft/reviewers

[bizley]

I like the idea but it put some technical burden on us with versions and fixes for 2.0.49, basically it would have to be 2.0.49.1 and so on. I know we are doing it right now and we are not semver compatible but still, just to remember.

[rob006]

@bizley I proposed this instead of releasing 2.2. In that case it should be less work than currently planned for 2.2.

With PHP 7.3 as a new minimum we could use phpunit 9 and cover ~90% of users. In that case 2.0.49.x could receive only security fixes, and master branch could be developed more easily than now.

[terabytesoftw]

I think it is useful to keep the 2.2 branch, i will continue removing the deprecations, and i will keep the branch, once the open PR is merged, i will continue working on it.

[schmunk42]

Just FYI: I am having some PHP extension issues with 8.3, see also https://github.com/yiisoft/yii2-docker/actions/runs/6183881486/job/16786492326#step:9:4677

[terabytesoftw]

#20074 done :)

[terabytesoftw]

@schmunk42 The test is already fixed, now the image can generate.

[schmunk42]

Here you go :)
https://hub.docker.com/r/yiisoftware/yii2-php/tags?page=1&name=8.3

I've also triggered a full build, but it'll need about 1.5h

[terabytesoftw]

Awesome, thks,

[schmunk42]

Doesn't build on arm64 😕 - https://github.com/yiisoft/yii2-docker/actions/runs/6979511769/job/18992949588#step:13:5408

I'll drop a note at Imagick/imagick#616

[bizley]

It looks like basically we will do that same thing that @rob006 is suggesting but we will brand it differently - 2.2 will be our 2.0.50-ish with PHP version bumped and all versions after 2.0.49-ish will get only bug and security fixes.

[rob006]

If you know what you are doing you can use 2.2.0 as 2.0.999 as a constraint.

That will create problems if some extensions will update their constraint to ~2.2.0 :D

My point is, if we only want to bump required PHP version without actual BC breaks, then it is not worth to release it as 2.2.0. I'm sure 2.2.0 will divide Yii 2 ecosystem, so it would be better to avoid it unless there are some clear benefits of it.

[bizley]

If 2.2 goes as some port between v2 and v3 I would keep it as 2.2 (and I would bump php to 7.3 (7.4?) on the 2.0). If the "port" is not a thing we could indeed only do the bump on 2.0.

[schmunk42]

I'm sure 2.2.0 will divide Yii 2 ecosystem

To be honest, the Yii2 extension ecosystem is not very active anymore - sadly.
You could also argue, that this could help breathe life into the ecosystem. But your points are valid.

Personally or for our company, we'll try to move to Yii 3 - sometime :) We basically have to fork 50% of 3rd party extensions anyway now.

[terabytesoftw]

I suggest making a list of the extensions to fork, and we can move it to yiicontrib for example where we can help maintain them among several.

[mtangoo]

https://github.com/hosannahighertech/yii2-dynamicform

[mtangoo]

On this, AFAIU, 2.2 is supposed to be a bridge to 3.x as well as adding new BC compatibilities.
To be able to do that we should free 2.2 from 2.0.x

[terabytesoftw]

If you agree, i will make a draft of uploading the master branch as proposed by @rob006 almost PHP 7.3, we must eliminate the PHPUNIT patch.

[terabytesoftw]

@cebe @samdark @machour @rhertogh @mtangoo @SilverFire @schmunk42 @bizley @rob006

1. 7.3
2. 7.4

#19959

What do you think about uploading the main version of the framework, in the master branch to 7.3 or 7.4 at least, will that allow us to remove the patches, add support for PHP 8.3 and continue moving forward?

[rob006]

Yii extensions can (and should) define their PHP requirements independently. yii2-queue could set their PHP requirement to PHP 8.1 if that would be required, there is no need to force it through framework.

[terabytesoftw]

@rob006 The applications have php 7.4, some extensions 7.4, would it make sense for all the extensions to have 7.4 ?

[rob006]

This is unrelated IMO. App templates are dedicated for new projects, so it make sense to target never version of PHP. But framework and extensions are mostly used by existing apps, so the lower the required PHP is, the more people will be able to use it.

[terabytesoftw]

Well, I don't really understand why I should update my legacy application. Shouldn't I keep all my dependencies the same? If I want to start a new project, should I use the latest PHP versions? Currently, many extensions and tests fail from PHP 8.0 and above. It will also be challenging to test older PHP versions, as CI systems work with newer controllers and OS versions. This will make maintenance and bug fixing more difficult. At some point, the framework will lack tests and slowly fade away. Those are my two cents.

For example, the framework supports 8.1 and 8.2, but due to the lack of updated tests in the extensions, some inconvenient issues may arise, as seen in yii2-authclient:

PHP Deprecated:  rawurlencode(): Passing null to parameter #1 ($string) of type string is deprecated in /home/runner/work/yii2-authclient/yii2-authclient/src/OAuth1.php on line 375
PHP Deprecated:  strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /home/runner/work/yii2-authclient/yii2-authclient/src/OAuth1.php on line 338
PHP Deprecated:  rawurlencode(): Passing null to parameter #1 ($string) of type string is deprecated in /home/runner/work/yii2-authclient/yii2-authclient/src/OAuth1.php on line 350
PHP Deprecated:  rawurlencode(): Passing null to parameter #1 ($string) of type string is deprecated in /home/runner/work/yii2-authclient/yii2-authclient/src/OAuth1.php on line 375
PHP Deprecated:  strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /home/runner/work/yii2-authclient/yii2-authclient/src/OAuth1.php on line 338
PHP Deprecated:  rawurlencode(): Passing null to parameter #1 ($string) of type string is deprecated in /home/runner/work/yii2-authclient/yii2-authclient/src/OAuth1.php on line 350
PHP Deprecated:  rawurlencode(): Passing null to parameter #1 ($string) of type string is deprecated in /home/runner/work/yii2-authclient/yii2-authclient/src/OAuth1.php on line 375
PHP Deprecated:  strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /home/runner/work/yii2-authclient/yii2-authclient/src/OAuth1.php on line 338
PHP Deprecated:  rawurlencode(): Passing null to parameter #1 ($string) of type string is deprecated in /home/runner/work/yii2-authclient/yii2-authclient/src/OAuth1.php on line 350
PHP Deprecated:  rawurlencode(): Passing null to parameter #1 ($string) of type string is deprecated in /home/runner/work/yii2-authclient/yii2-authclient/src/OAuth1.php on line 375
PHP Deprecated:  strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /home/runner/work/yii2-authclient/yii2-authclient/src/OAuth1.php on line 338
PHP Deprecated:  rawurlencode(): Passing null to parameter #1 ($string) of type string is deprecated in /home/runner/work/yii2-authclient/yii2-authclient/src/OAuth1.php on line 350
PHP Deprecated:  rawurlencode(): Passing null to parameter #1 ($string) of type string is deprecated in /home/runner/work/yii2-authclient/yii2-authclient/src/OAuth1.php on line 375
PHP Deprecated:  strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /home/runner/work/yii2-authclient/yii2-authclient/src/OAuth1.php on line 338
PHP Deprecated:  rawurlencode(): Passing null to parameter #1 ($string) of type string is deprecated in /home/runner/work/yii2-authclient/yii2-authclient/src/OAuth1.php on line 350
PHP Deprecated:  rawurlencode(): Passing null to parameter #1 ($string) of type string is deprecated in /home/runner/work/yii2-authclient/yii2-authclient/src/OAuth1.php on line 375
PHP Deprecated:  trim(): Passing null to parameter #1 ($string) of type string is deprecated in /home/runner/work/yii2-authclient/yii2-authclient/vendor/yiisoft/yii2/web/UrlManager.php on line 4[16](https://github.com/yiisoft/yii2-authclient/actions/runs/6357266711/job/17268159083?pr=379#step:9:17)

And as you can see, deprecations are not only in the extension but also in the framework itself.

[forwzb]

I really hope to do this in yi 3, make yi 3, and then make some changes to 2, because there are too many changes in 3, even if 2 is compatible, the final iteration will update the project code, Ythis. I think yi 3 should be sent first.

[terabytesoftw]

yiisoft/yii2-queue#473 (comment) @s1lver

[s1lver]

I can add more to this comment)

Not time long ago (in May) I restored the launch of tests in the yii2-queue package. I encountered problems with the loss of support for Debian and Composer images, and not to mention the fact that I have to sit on old driver packages when they are far ahead. I must say it was not pleasant)

For this package, I would suggest locking the version, with all the latest fixes, to 2.3.6. The 2.3.* branch will remain at the maximum version of PHP 8.0. And starting with version 2.4.0, make the minimum version of PHP 8.1.

[terabytesoftw]

7.4 would not serve as the minimum PHP version ?

[s1lver]

Some dependent packages will not allow this in order to have the latest fixes. Well, here, I think that there is no need to apply a general restriction for PHP 7.4

[s1lver]

You can, of course, make the minimum version 8.0, but it’s still better to leave 8.0 as the final version for the 2.3.* branch