Address review comments

yufengwangca · yufengwangca · commit 7734f35d7862 · 2025-10-21T15:24:08.000-07:00
diff --git a/examples/camera-app/linux/src/clusters/webrtc-provider/webrtc-provider-manager.cpp b/examples/camera-app/linux/src/clusters/webrtc-provider/webrtc-provider-manager.cpp
@@ -991,12 +991,12 @@ CHIP_ERROR WebRTCProviderManager::SendICECandidatesCommand(Messaging::ExchangeMa
     for (const auto & candidateInfo : localCandidates)
     {
         ICECandidateStruct iceCandidate;
-        iceCandidate.candidate = CharSpan::fromCharString(candidateInfo.candidate.c_str());
+        iceCandidate.candidate = CharSpan(candidateInfo.candidate.data(), candidateInfo.candidate.size());
 
         // Set SDPMid if available
         if (!candidateInfo.mid.empty())
         {
-            iceCandidate.SDPMid.SetNonNull(CharSpan::fromCharString(candidateInfo.mid.c_str()));
+            iceCandidate.SDPMid.SetNonNull(CharSpan(candidateInfo.mid.data(), candidateInfo.mid.size()));
         }
         else
         {
diff --git a/examples/camera-controller/webrtc-manager/WebRTCProviderClient.cpp b/examples/camera-controller/webrtc-manager/WebRTCProviderClient.cpp
@@ -182,12 +182,12 @@ CHIP_ERROR WebRTCProviderClient::ProvideICECandidates(uint16_t webRTCSessionId,
     for (const auto & candidateInfo : mClientICECandidates)
     {
         ICECandidateStruct iceCandidate;
-        iceCandidate.candidate = CharSpan::fromCharString(candidateInfo.candidate.c_str());
+        iceCandidate.candidate = CharSpan(candidateInfo.candidate.data(), candidateInfo.candidate.size());
 
         // Set SDPMid if available
         if (!candidateInfo.mid.empty())
         {
-            iceCandidate.SDPMid.SetNonNull(CharSpan::fromCharString(candidateInfo.mid.c_str()));
+            iceCandidate.SDPMid.SetNonNull(CharSpan(candidateInfo.mid.data(), candidateInfo.mid.size()));
         }
         else
         {

Original file line number	Diff line number	Diff line change
`@@ -991,12 +991,12 @@ CHIP_ERROR WebRTCProviderManager::SendICECandidatesCommand(Messaging::ExchangeMa`
`991`	`991`	`for (const auto & candidateInfo : localCandidates)`
`992`	`992`	`{`
`993`	`993`	`ICECandidateStruct iceCandidate;`
`994`		`- iceCandidate.candidate = CharSpan::fromCharString(candidateInfo.candidate.c_str());`
	`994`	`+ iceCandidate.candidate = CharSpan(candidateInfo.candidate.data(), candidateInfo.candidate.size());`
`995`	`995`
`996`	`996`	`// Set SDPMid if available`
`997`	`997`	`if (!candidateInfo.mid.empty())`
`998`	`998`	`{`
`999`		`- iceCandidate.SDPMid.SetNonNull(CharSpan::fromCharString(candidateInfo.mid.c_str()));`
	`999`	`+ iceCandidate.SDPMid.SetNonNull(CharSpan(candidateInfo.mid.data(), candidateInfo.mid.size()));`
`1000`	`1000`	`}`
`1001`	`1001`	`else`
`1002`	`1002`	`{`
Original file line number	Diff line number	Diff line change
`@@ -182,12 +182,12 @@ CHIP_ERROR WebRTCProviderClient::ProvideICECandidates(uint16_t webRTCSessionId,`
`182`	`182`	`for (const auto & candidateInfo : mClientICECandidates)`
`183`	`183`	`{`
`184`	`184`	`ICECandidateStruct iceCandidate;`
`185`		`- iceCandidate.candidate = CharSpan::fromCharString(candidateInfo.candidate.c_str());`
	`185`	`+ iceCandidate.candidate = CharSpan(candidateInfo.candidate.data(), candidateInfo.candidate.size());`
`186`	`186`
`187`	`187`	`// Set SDPMid if available`
`188`	`188`	`if (!candidateInfo.mid.empty())`
`189`	`189`	`{`
`190`		`- iceCandidate.SDPMid.SetNonNull(CharSpan::fromCharString(candidateInfo.mid.c_str()));`
	`190`	`+ iceCandidate.SDPMid.SetNonNull(CharSpan(candidateInfo.mid.data(), candidateInfo.mid.size()));`
`191`	`191`	`}`
`192`	`192`	`else`
`193`	`193`	`{`