Skip to content

fix: config watcher follow symlinks #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: config watcher follow symlinks #361

wants to merge 1 commit into from

Conversation

Bubbleioa
Copy link

@yujqiao
Copy link
Member

yujqiao commented Jun 17, 2025

This one I'm a bit hesitated. If the config is /etc/rathole.toml, this will result in watching every file change under /etc

@yujqiao
Copy link
Member

yujqiao commented Jun 17, 2025

That said, I cannot think of another way to fix symlink. readlink -f probably will fail when the file is edited by vim because the inode number could change. Can we watch recursively only when the target file is a symlink? so we can limit the impact

yujqiao
yujqiao requested changes Jun 17, 2025
View reviewed changes
Copy link
Member

@yujqiao yujqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think the current approach can be merged given comments above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yujqiao yujqiao yujqiao requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bubbleioa @yujqiao