Skip to content

Commit c11a554

Browse files
authored
Merge pull request #32 from zerodha/fix-kiteversion
chore: use kiteVersion property consistently for X-Kite-Version headers
2 parents 40287e8 + f006982 commit c11a554

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/KiteConnect.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1491,7 +1491,7 @@ private function request(string $route, string $method, array $params, string $h
14911491
$request_headers = [
14921492
"Content-Type" => $content_type,
14931493
"User-Agent" => "phpkiteconnect/" . self::VERSION,
1494-
"X-Kite-Version" => 3,
1494+
"X-Kite-Version" => $this->kiteVersion,
14951495
];
14961496

14971497
if ($this->apiKey && $this->accessToken) {

tests/KiteTickerTest.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public function setUp(): void
1717
}
1818

1919
/**
20-
* Test LTP mode tick data - matches TypeScript ltpModeTick test
20+
* Test LTP mode tick data
2121
*/
2222
public function testLtpModeTick()
2323
{
@@ -35,7 +35,7 @@ public function testLtpModeTick()
3535
}
3636

3737
/**
38-
* Test Quote mode tick data - matches TypeScript quoteModeTick test
38+
* Test Quote mode tick data
3939
*/
4040
public function testQuoteModeTick()
4141
{
@@ -54,7 +54,7 @@ public function testQuoteModeTick()
5454
}
5555

5656
/**
57-
* Test Full mode tick data - matches TypeScript fullModeTick test
57+
* Test Full mode tick data
5858
*/
5959
public function testFullModeTick()
6060
{
@@ -73,15 +73,15 @@ public function testFullModeTick()
7373
}
7474

7575
/**
76-
* Read binary packets - matches TypeScript readBufferPacket function
76+
* Read binary packets
7777
*/
7878
private function readBufferPacket(string $fileName): string
7979
{
8080
return file_get_contents(__DIR__ . '/' . $fileName);
8181
}
8282

8383
/**
84-
* Convert buffer to binary buffer array - matches TypeScript toArrayBuffer function
84+
* Convert buffer to binary buffer array
8585
*/
8686
private function toArrayBuffer(string $tickerMode): string
8787
{

0 commit comments

Comments
 (0)