fix(goctl): Fix getting swagger consume types #4903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files🚀 New features to boost your workflow:
|
jaronnie
force-pushed
the
fix/goctl-swagger
branch
from
f546b98 to
97c036f
Compare
kesonan
reviewed
May 28, 2025
| structType, ok := tp.(spec.DefineStruct) | ||
| if !ok { | ||
|
|
||
| if tp == nil { |
There was a problem hiding this comment.
why not use original conditions?
There was a problem hiding this comment.
I have corrected it
jaronnie
force-pushed
the
fix/goctl-swagger
branch
from
97c036f to
54d1ed5
Compare
kesonan
reviewed
Jun 3, 2025
tools/goctl/api/swagger/swagger.go
Outdated
| if t.Key == tag { | ||
| return true | ||
| } | ||
| func typeContainsTag(ctx Context, tp apiSpec.Type, tag string) bool { |
There was a problem hiding this comment.
func typeContainsTag(ctx Context, structType apiSpec.DefineStruct, tag string)
kesonan
reviewed
Jun 3, 2025
| @@ -11,14 +11,16 @@ func consumesFromTypeOrDef(ctx Context, method string, tp spec.Type) []string { | |||
| if strings.EqualFold(method, http.MethodGet) { | |||
| return []string{} | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
consumesFromTypeOrDef this function need not changed.
There was a problem hiding this comment.
but expandMembers function need apiSpec.Type
There was a problem hiding this comment.
understand, I have corrected it
fix(goctl): Fix getting swagger consume types fix(goctl): Fix getting swagger consume types fix(goctl): Fix getting swagger consume types
jaronnie
force-pushed
the
fix/goctl-swagger
branch
from
54d1ed5 to
a923252
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4898