feat: drop leaderless party (#52)

* Refactor request msg_id

* Drop leaderless parties

* Fix naming

* Remove sorting

* Enforce version, improve logging

* Fix tests

* Remove dial to self

* Drop legacy proto

* Lint

* Merge files

* Address PR comments [1]

* Address PR comments [2]

* Fix log

Author: swift1337

blame/policy.go

@@ -78,7 +78,7 @@ func (m *Manager) GetUnicastBlame(lastMsgType string) ([]Node, error) {
 	peersID, ok := m.lastUnicastPeer[lastMsgType]
 	m.lastMsgLocker.RUnlock()
 	if !ok {
-		return nil, fmt.Errorf("fail to find peers of the given msg type %w", ErrTssTimeOut)
+		return nil, fmt.Errorf("fail to find peers of the given msg type %w", ErrTimeoutTSS)
 	}
 	for _, el := range peersID {
 		peersMap[el.String()] = true
@@ -91,7 +91,7 @@ func (m *Manager) GetUnicastBlame(lastMsgType string) ([]Node, error) {
 	_, blamePeers, err := m.GetBlamePubKeysLists(onlinePeers)
 	if err != nil {
 		m.logger.Error().Err(err).Msg("fail to get the blamed peers")
-		return nil, fmt.Errorf("fail to get the blamed peers %w", ErrTssTimeOut)
+		return nil, fmt.Errorf("fail to get the blamed peers %w", ErrTimeoutTSS)
 	}
 	var blameNodes []Node
 	for _, el := range blamePeers {
@@ -105,7 +105,7 @@ func (m *Manager) GetBroadcastBlame(lastMessageType string) ([]Node, error) {
 	blamePeers, err := m.tssTimeoutBlame(lastMessageType, m.partyInfo.PartyIDMap)
 	if err != nil {
 		m.logger.Error().Err(err).Msg("fail to get the blamed peers")
-		return nil, fmt.Errorf("fail to get the blamed peers %w", ErrTssTimeOut)
+		return nil, fmt.Errorf("fail to get the blamed peers %w", ErrTimeoutTSS)
 	}
 	var blameNodes []Node
 	for _, el := range blamePeers {

blame/types.go

@@ -19,7 +19,7 @@ var (
 	ErrHashFromOwner     = errors.New(" hash sent from data owner")
 	ErrNotEnoughPeer     = errors.New("not enough nodes to evaluate hash")
 	ErrNotMajority       = errors.New("message we received does not match the majority")
-	ErrTssTimeOut        = errors.New("error Tss Timeout")
+	ErrTimeoutTSS        = errors.New("error timeout TSS")
 	ErrHashCheck         = errors.New("error in processing hash check")
 	ErrHashInconsistency = errors.New("fail to agree on the hash value")
 )

keygen/ecdsa/keygen_test.go

@@ -95,7 +95,7 @@ func (s *TssECDSAKeygenTestSuite) SetUpSuite(c *C) {
 }
 
 func (s *TssECDSAKeygenTestSuite) TearDownSuite(c *C) {
-	for i, _ := range s.comms {
+	for i := range s.comms {
 		tempFilePath := path.Join(os.TempDir(), strconv.Itoa(i), "ecdsa")
 		err := os.RemoveAll(tempFilePath)
 		c.Assert(err, IsNil)

keygen/ecdsa/tss_keygen.go

@@ -217,7 +217,7 @@ func (tKeyGen *TssKeyGen) processKeyGen(errChan chan struct{},
 					blameMgr.GetBlame().IsUnicast = isUnicast
 				}
 			}
-			return nil, blame.ErrTssTimeOut
+			return nil, blame.ErrTimeoutTSS
 
 		case msg := <-outCh:
 			tKeyGen.logger.Debug().Msgf(">>>>>>>>>>msg: %s", msg.String())

keygen/eddsa/tss_keygen.go

@@ -205,7 +205,7 @@ func (tKeyGen *KeyGen) processKeyGen(errChan chan struct{},
 					blameMgr.GetBlame().IsUnicast = isUnicast
 				}
 			}
-			return nil, blame.ErrTssTimeOut
+			return nil, blame.ErrTimeoutTSS
 
 		case msg := <-outCh:
 			tKeyGen.logger.Debug().Msgf(">>>>>>>>>>msg: %s", msg.String())

keygen/keygen.go

@@ -1,14 +1,70 @@
 package keygen
 
 import (
-	bcrypto "github.com/bnb-chain/tss-lib/crypto"
+	"bytes"
+	"strings"
 
+	"github.com/bnb-chain/tss-lib/crypto"
+
+	"github.com/zeta-chain/go-tss/blame"
 	"github.com/zeta-chain/go-tss/common"
 	"github.com/zeta-chain/go-tss/p2p"
 )
 
-type TssKeyGen interface {
-	GenerateNewKey(keygenReq Request) (*bcrypto.ECPoint, error)
+// Service TSS key generation service
+type Service interface {
+	GenerateNewKey(request Request) (*crypto.ECPoint, error)
 	GetTssKeyGenChannels() chan *p2p.Message
 	GetTssCommonStruct() *common.TssCommon
 }
+
+// Request request to do keygen
+type Request struct {
+	Keys        []string    `json:"keys"`
+	BlockHeight int64       `json:"block_height"`
+	Version     string      `json:"tss_version"`
+	Algo        common.Algo `json:"algo,omitempty"`
+}
+
+// NewRequest constructs Request.
+func NewRequest(keys []string, blockHeight int64, version string, algo common.Algo) Request {
+	return Request{
+		Keys:        keys,
+		BlockHeight: blockHeight,
+		Version:     version,
+		Algo:        algo,
+	}
+}
+
+// MsgID returns the hash of the request.
+func (r *Request) MsgID() (string, error) {
+	var b bytes.Buffer
+
+	b.WriteString(r.Version)
+	b.WriteByte(';')
+	b.WriteString(string(r.Algo))
+	b.WriteByte(';')
+	b.WriteString(strings.Join(r.Keys, ","))
+
+	return common.MsgToHashString(b.Bytes())
+}
+
+// Response keygen response
+type Response struct {
+	Algo        common.Algo   `json:"algo"`
+	PubKey      string        `json:"pub_key"`
+	PoolAddress string        `json:"pool_address"`
+	Status      common.Status `json:"status"`
+	Blame       blame.Blame   `json:"blame"`
+}
+
+// NewResponse create a new instance of keygen.Response
+func NewResponse(algo common.Algo, pk, addr string, status common.Status, blame blame.Blame) Response {
+	return Response{
+		Algo:        algo,
+		PubKey:      pk,
+		PoolAddress: addr,
+		Status:      status,
+		Blame:       blame,
+	}
+}

keygen/request.go

@@ -288,7 +288,7 @@ func (tKeySign *TssKeySign) processKeySign(
 				}
 			}
 
-			return nil, blame.ErrTssTimeOut
+			return nil, blame.ErrTimeoutTSS
 		case msg := <-outCh:
 			tKeySign.logger.Debug().Msgf(">>>>>>>>>>key sign msg: %s", msg.String())
 			tKeySign.tssCommonStruct.GetBlameMgr().SetLastMsg(msg)

keygen/response.go

@@ -287,7 +287,7 @@ func (tKeySign *KeySign) processKeySign(
 				}
 			}
 
-			return nil, blame.ErrTssTimeOut
+			return nil, blame.ErrTimeoutTSS
 		case msg := <-outCh:
 			tKeySign.logger.Debug().Msgf(">>>>>>>>>>key sign msg: %s", msg.String())
 			tKeySign.tssCommonStruct.GetBlameMgr().SetLastMsg(msg)