Skip to content

Commit f6f83b4

Browse files
swift1337skosito
andauthored
feat: add more logs (#61)
* Add more log fields * Update tss/keysign.go Co-authored-by: skosito <[email protected]> --------- Co-authored-by: skosito <[email protected]>
1 parent 2d9bfc8 commit f6f83b4

File tree

4 files changed

+19
-7
lines changed

4 files changed

+19
-7
lines changed

keysign/signature_notifier.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,11 @@ func (s *SignatureNotifier) sendOneMsgToPeer(m *signatureItem) error {
217217

218218
ack := make([]byte, expectedResponseSize)
219219
if _, err := stream.Read(ack); err != nil {
220-
return errors.Wrapf(err, "failed to read response from stream")
220+
return errors.Wrapf(
221+
err,
222+
"failed to read response from stream (timeout: %s)",
223+
config.SigNotifierAckTimeout.String(),
224+
)
221225
}
222226

223227
return err

logs/fields.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ const (
77
Component = "component"
88
MsgID = "msg_id"
99
Peer = "peer"
10-
Host = "host"
11-
Leader = "leader"
10+
Host = "p2p_host"
11+
Leader = "p2p_leader"
1212
Latency = "latency"
1313
)
1414

p2p/party_coordinator.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -385,7 +385,7 @@ func (pc *PartyCoordinator) joinPartyMember(
385385
case peerGroup.getLeaderResponse().Type == messages.JoinPartyLeaderComm_Success:
386386
return pIDs, nil
387387
default:
388-
return pIDs, ErrJoinPartyTimeout
388+
return pIDs, errors.Wrapf(ErrJoinPartyTimeout, "(timeout: %s)", pc.timeout.String())
389389
}
390390
}
391391

tss/keysign.go

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -121,8 +121,13 @@ func (t *Server) generateSignature(
121121
t.logger.Error().
122122
Err(errJoinParty).
123123
Str(logs.MsgID, msgID).
124+
Str(logs.Peer, t.p2pCommunication.GetLocalPeerID()).
125+
Stringer(logs.Leader, leader).
126+
Any("peers_count", len(onlinePeers)).
124127
Any("peers", onlinePeers).
125-
Msg("Failed to form keysign party with online peers")
128+
Int64("block_height", req.BlockHeight).
129+
Any("blame_leader", blameLeader).
130+
Msg("Failed to form keysign party")
126131

127132
return keysign.Response{
128133
Status: common.Fail,
@@ -325,14 +330,17 @@ func (t *Server) KeySign(req keysign.Request) (keysign.Response, error) {
325330
case errors.Is(errWait, p2p.ErrSigGenerated):
326331
// ok, we generate the signature ourselves
327332
case errWait != nil:
328-
t.logger.Error().Err(errWait).Msg("waitForSignatures returned error")
333+
t.logger.Error().
334+
Str(logs.MsgID, msgID).
335+
Err(errWait).
336+
Msg("Keysign: waitForSignatures failed")
329337
default:
330338
// we received an valid signature
331339
sigChan <- p2p.NotificationSigReceived
332340
t.logger.Debug().
333341
Str(logs.MsgID, msgID).
334342
Stringer(logs.Peer, receivedSig.Blame).
335-
Msg("received signature")
343+
Msg("Keysign: received signature")
336344
}
337345
}()
338346

0 commit comments

Comments
 (0)