p2p/communication.go (1)

57-85: External DNS fallback is solid; prefer /dns over /dns4 and log precedence when both are set

• Using /dns4 restricts to IPv4-only. Unless you explicitly want v4-only, advertise /dns to allow either family.
• If both ExternalIP and ExternalDNS are provided, log a clear precedence warning to aid ops/debugging.

Apply this diff:

 func NewCommunication(
   bootstrapPeers []maddr.Multiaddr,
   port int,
   externalIP string,
-  externalDNS string,
+  externalDNS string,
   whitelistedPeers []peer.ID,
   logger zerolog.Logger,
 ) (*Communication, error) {
   logger = logger.With().Str(logs.Component, "communication").Logger()
@@
- if len(externalIP) != 0 {
+ if len(externalIP) != 0 {
+   if len(externalDNS) != 0 {
+     logger.Warn().Str("external_ip", externalIP).Str("external_dns", externalDNS).
+       Msg("Both ExternalIP and ExternalDNS provided; ExternalIP takes precedence")
+   }
   myself := fmt.Sprintf("/ip4/%s/tcp/%d", externalIP, port)
   externalAddr, err = maddr.NewMultiaddr(myself)
   if err != nil {
     return nil, errors.Wrapf(err, "external addr %q", myself)
   }
 } else if len(externalDNS) != 0 {
   // externalDNS is used as a fallback when externalIP is not set
-  myself := fmt.Sprintf("/dns4/%s/tcp/%d", externalDNS, port)
+  myself := fmt.Sprintf("/dns/%s/tcp/%d", externalDNS, port)
   externalAddr, err = maddr.NewMultiaddr(myself)
   if err != nil {
     return nil, errors.Wrapf(err, "external addr %q", myself)
   }
 }

p2p/communication_test.go (3)

22-22: Call site updates look correct; add a test asserting IP precedence over DNS

All call sites updated to pass the new externalDNS argument. Please add a test that sets both ExternalIP and ExternalDNS and asserts that the advertised address is the IP-based multiaddr (to lock in precedence).

Example test to add (outside the modified ranges):

func (CommunicationTestSuite) TestEstablishP2pCommunication_IPTakesPrecedence(c *C) {
	log := logger("TestEstablishP2pCommunication_IPTakesPrecedence")

	fakeExternalIP := "11.22.33.44"
	fakeExternalDNS := "example.com"
	expected := "/ip4/11.22.33.44/tcp/3330"

	comm, err := NewCommunication(nil, 3330, fakeExternalIP, fakeExternalDNS, []peer.ID{}, log)
	c.Assert(err, IsNil)
	defer comm.Stop()

	priv := "6LABmWB4iXqkqOJ9H0YFEA2CSSx6bA7XAKGyI/TDtas="
	privKey, _ := base64.StdEncoding.DecodeString(priv)
	c.Assert(comm.Start(privKey), IsNil)

	c.Assert(checkExist(comm.host.Addrs(), expected), Equals, true)
}

Also applies to: 66-66, 72-72, 82-82, 89-97, 110-117

---

124-160: Use a reserved domain (example.com) in tests to avoid external coupling

Switch test DNS to example.com (RFC 2606) to avoid referencing a real domain.

Apply this diff:

-	fakeExternalDNS := "p2ptest.com"
-	fakeExternalDNSMultiAddr := "/dns4/p2ptest.com/tcp/2220"
+	fakeExternalDNS := "example.com"
+	fakeExternalDNSMultiAddr := "/dns4/example.com/tcp/2220"

---

137-139: Extract shared test-only bootstrap private key constant

The base64 private key is present in multiple tests and is flagged by secret scanners — centralize it and annotate intent.

Occurrences to update:

• p2p/communication_test.go (lines ~59, ~137)
• keygen/eddsa/keygen_test.go (line ~41)
• keygen/ecdsa/keygen_test.go (line ~45)
• keysign/eddsa/keysign_test.go (line ~43)
• keysign/ecdsa/keysign_test.go (line ~46)

Add a single test-only constant (e.g., in a small test helper package/file) and replace literals with it:

const TestBootstrapPrivKeyBase64 = "6LABmWB4iXqkqOJ9H0YFEA2CSSx6bA7XAKGyI/TDtas=" // test-only key; safe for public tests

Replace each bootstrapPrivKey := "..." with bootstrapPrivKey := testutil.TestBootstrapPrivKeyBase64 (or the chosen import path).

tss/tss_4nodes_zeta_test.go (1)

255-256: NetworkConfig updated correctly to include ExternalDNS

The empty ExternalDNS in tests keeps behavior unchanged; good alignment with the new config surface.

Consider adding a test path that sets ExternalDNS non-empty (mirroring p2p tests) in an end-to-end flow to validate propagation through Server.New.

tss/tss.go (1)

63-64: Document ExternalDNS semantics in NetworkConfig

Add a field comment clarifying that ExternalDNS is used only when ExternalIP is empty and that a DNS-based multiaddr will be advertised.

Example:

// ExternalDNS is advertised as a /dns or /dns4 multiaddr when ExternalIP is empty.
ExternalDNS string

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

keygen/eddsa/keygen_test.go (1)

113-113: DRY up repeated constructor usage with a small helper.

Multiple tests repeat the same NewCommunication(...) arguments, which increases churn when signatures evolve. Consider a helper to centralize this.

Example helper for tests (place in a test-only file, e.g., keygen/eddsa/comm_test_helpers.go):

package eddsa

import (
	maddr "github.com/multiformats/go-multiaddr"
	"github.com/libp2p/go-libp2p/core/peer"
	zlog "github.com/rs/zerolog/log"
	"github.com/zeta-chain/go-tss/p2p"
)

func newTestComm(bootstrapPeers []maddr.Multiaddr, port int, whitelisted []peer.ID) (*p2p.Communication, error) {
	return p2p.NewCommunication(bootstrapPeers, port, "", "", whitelisted, zlog.Logger)
}

Then replace call sites with:

comm, err := newTestComm(nil /* or bootstrapPeers */, ports[i], whitelistedPeers)

Also applies to: 119-119

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.