Skip to content

Add golangci-lint #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jun 30, 2025
Merged

Add golangci-lint #1086

merged 17 commits into from
Jun 30, 2025

Conversation

tkan145
Copy link
Contributor

@tkan145 tkan145 commented May 13, 2025

TBA

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 13, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tkan145 tkan145 marked this pull request as ready for review May 13, 2025 02:37
@tkan145 tkan145 requested a review from a team as a code owner May 13, 2025 02:37
@briangallagher
Copy link
Contributor

briangallagher commented Jun 25, 2025 •
edited
Loading

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)

eguzki
eguzki approved these changes Jun 30, 2025
View reviewed changes
Copy link
Member

@eguzki eguzki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner and "standard" code 🎖️

@tkan145 tkan145 merged commit a5e494f into 3scale:master Jun 30, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eguzki eguzki eguzki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tkan145 @briangallagher @eguzki @openshift-merge-robot