Skip to content

Conversation

lrq3000
Copy link

@lrq3000 lrq3000 commented Mar 13, 2018

This PR fixes various issues:

  • arguments not being accounted (ie, cannot set value parameter).
  • the pixelation of transparent images (leaving an icon in the top left corner + becoming more and more blurry if you hover in/out multiple times, because it got redrawn on the same canvas without clearing over and over again).

This also adds code comments and update the readme and add a license to be detected by Github.

lrq3000 added 2 commits March 13, 2018 17:08
…sparent images + add comments + bump v0.5

Signed-off-by: Stephen L. <[email protected]>
@43081j
Copy link
Owner

43081j commented Mar 13, 2018

This is going to be a real pain (sorry), but i just bumped the version and released a cleanup to master.

Could you have a go at rebasing your branch onto it?

After rebasing, could you then run npm run build to do any linting and re-generate the minified file using the new config?

p.s. it'll give you quite a few conflicts during rebase, again sorry for that but this really needed cleaning up.

if you need any help, give me a shout and ill be around.

@lrq3000
Copy link
Author

lrq3000 commented Mar 13, 2018

Haha what a coincidence! I did not expect this repo to be updated since the last was 4 years ago!

It doesn't seem like there are that many changes, I will try to have a look if I get some time :-)

However note that my changes were made only to the standalone script, not the jquery one, so maybe these changes will have to be copied over there too (but I don't know enough about jquery to do that myself).

@43081j
Copy link
Owner

43081j commented Mar 13, 2018

no coincidence 🙈 saw your PR, then saw my code and couldn't resist cleaning up what past-james wrote :p

so i am responsible for the horrid rebase you may have to do, but ill be here to help if needed 😶

dont worry about jquery, its the same file, it basically checks if jquery is defined (in a silly way, which we should probably change) and adds its self as an extension method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants