Remove extra leading space on tag names in ComicInfo #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Komga might be stripping these out but on LANraragi this causes an issue. Visually it removes it from the links the labels but it fails to find anything unless you go up and add that extra space into the search. I've removed it and checked both Komga and LANraragi. Komga still works normally and LANraragi now searches proper.
|
Please do your own validation before merging but my testing showed Komga was unaffected and LANraragi had it's issue fixed. This impacts all ComicInfo.xml files generated up until now as those still have that leading space. |
|
Personally would like this to be optional, don't want my current collection to be "outdated." Simple config setting for LANraragi compatability would be appreciated. |
|
I can do that. |
|
What about tags that contain spaces in their names? Does this change also improve things for these tags? I think it would look pretty shitty with tags that contain spaces, like "tag:big tits" |
9-FS
force-pushed
the
dev
branch
4 times, most recently
from
e4ea1f4 to
5507710
Compare
9-FS
force-pushed
the
dev
branch
19 times, most recently
from
1fd3f8a to
3df460f
Compare
9-FS
force-pushed
the
dev
branch
9 times, most recently
from
62e9f65 to
8d84e45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Komga might be stripping these out but on LANraragi this causes an issue. Visually it removes it from the links the labels but it fails to find anything unless you go up and add that extra space into the search. I've removed it and checked both Komga and LANraragi. Komga still works normally and LANraragi now searches proper.