Update the megablox kernel utility function to support float16 #1423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the megablox kernel utility function to also cover float16.
wang2yn84
requested review from
gobbleturk,
khatwanimohit,
bvandermoon,
vipannalla,
RissyRan,
richjames0,
rni418,
gagika,
shralex,
yangyuwei,
SurbhiJainUSC,
hengtaoguo,
A9isha and
wyzhang
as code owners
yangyuwei
approved these changes
Mar 19, 2025
bvandermoon
approved these changes
Mar 19, 2025
That's a good question. Which script shall I run to validate the change? |
@yangyuwei do you have a GPU-specific test that @wang2yn84 could use here? |
RissyRan
reviewed
Mar 22, 2025
| @@ -55,5 +55,7 @@ def select_input_dtype(lhs: jnp.ndarray, rhs: jnp.ndarray) -> jnp.dtype: | |||
| # input precision, we need to convert bf16 argument to fp32 beforehand. | |||
| if supports_bfloat16_matmul() and lhs.dtype == jnp.bfloat16 and rhs.dtype == jnp.bfloat16: | |||
| return jnp.bfloat16 | |||
| elif lhs.dtype == jnp.float16 and rhs.dtype == jnp.float16: | |||
There was a problem hiding this comment.
I am don't think any current test will cover newly added float16 type?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current function only switches between bf16 and f32. It should also take into consideration of f16.
Tests
No functional change. Reply on presubmit tests.
Checklist
Before submitting this PR, please make sure (put X in square brackets):