Skip to content

Conversation

halotukozak
Copy link
Member

This pull request updates Scala to version 2.13.17 across the project and introduces improvements to MongoDB client APIs by deprecating ambiguous methods and providing clearer alternatives. Additionally, it includes a minor fix in the Redis reply decoder implementation and improves macro handling of default and null values.

Dependency updates:

  • Updated Scala version from 2.13.16 to 2.13.17 in the build configuration (project/Commons.scala) and CI workflow (.github/workflows/ci.yml). [1] [2] [3]

MongoDB client API improvements:

  • Deprecated the ambiguous listDatabases and listCollections methods in TypedMongoClient and TypedMongoDatabase, replacing them with listRawDatabases, listTypedDatabases, listRawCollections, and listTypedCollections for clearer usage. [1] [2]

Macro system enhancements:

  • Improved handling of macro parameters by returning the default value when a parameter is set to null.

Redis decoder fix:

  • Fixed usage of function references in ReplyDecoders by explicitly passing the function

@halotukozak halotukozak requested review from ddworak and Copilot October 8, 2025 09:50
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates Scala to version 2.13.17 and improves API clarity by deprecating ambiguous MongoDB methods and providing clearer alternatives. It also includes fixes for Redis reply decoders and macro handling improvements.

  • Updated Scala version from 2.13.16 to 2.13.17 across build configuration and CI workflow
  • Deprecated ambiguous MongoDB methods and introduced clearer naming conventions with listRaw* and listTyped* alternatives
  • Fixed function reference usage in Redis reply decoders and improved macro null value handling

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
project/Commons.scala Updates Scala version to 2.13.17
.github/workflows/ci.yml Updates CI matrix to use Scala 2.13.17
redis/src/main/scala/com/avsystem/commons/redis/commands/ReplyDecoders.scala Fixes function reference usage by adding explicit underscore
mongo/jvm/src/main/scala/com/avsystem/commons/mongo/typed/TypedMongoClient.scala Deprecates ambiguous listDatabases and adds clear alternatives
mongo/jvm/src/main/scala/com/avsystem/commons/mongo/typed/TypedMongoDatabase.scala Deprecates ambiguous methods and adds clear alternatives, with incorrect method name
macros/src/main/scala/com/avsystem/commons/macros/MacroCommons.scala Improves macro handling of null values

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant