{username}-afk_{host}

[Creee9]

Important

Adds logged-in username to bucketname in AFKWatcher by introducing get_logged_in_user() in afk.py.

• Behavior:
  • Adds get_logged_in_user() function in afk.py to retrieve the current logged-in user using a shell command.
  • Updates AFKWatcher.__init__() to include the logged-in username in bucketname format as "{username}-afk_{host}".
• Error Handling:
  • Logs an error if the logged-in user cannot be retrieved, defaulting to "unknown".

^{This description was created by for 102465f. It will automatically update as commits are pushed.}

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to 102465f in 2 minutes and 15 seconds

More details

• Looked at 45 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 4 drafted comments based on config settings.

1. aw_watcher_afk/afk.py:32

• Draft comment:
  Using shell=True with a static command is acceptable, but ensure no future modifications allow untrusted input. Consider catching specific exceptions (e.g., subprocess.CalledProcessError) for clarity.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50%
  The comment is about security best practices, but it's more speculative ("ensure no future modifications") than pointing out a current issue. The exception handling suggestion is a minor improvement but not critical since the function already has error handling that accomplishes its goal. The command is indeed static and safe as-is.
  The suggestion about specific exception handling could make the code more maintainable. The security warning about shell=True is valid since it's a common source of vulnerabilities.
  However, the current code is safe as implemented, and the comment is more about potential future issues than current problems. The existing error handling is sufficient for the simple use case.
  The comment should be deleted as it's more speculative and advisory rather than pointing out a clear issue that needs fixing.

2. aw_watcher_afk/afk.py:58

• Draft comment:
  Ensure the new bucket naming convention (using username) is consistent across deployments, especially when the username returns 'unknown'.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50%
  None

3. aw_watcher_afk/afk.py:62

• Draft comment:
  Bucket naming now relies on the username from get_logged_in_user. Ensure that falling back to 'unknown' won't cause naming collisions or other issues.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50%
  This comment appears to be asking the author to verify/ensure something rather than pointing out a clear issue. The fallback to 'unknown' seems like a reasonable default that wouldn't cause naming collisions since it would still be combined with the unique hostname. The comment doesn't identify any specific problem that needs fixing.
  Maybe there could be a real issue with bucket naming collisions if multiple users get the 'unknown' fallback on the same host?
  Even if multiple users get 'unknown', they would likely be running their own instances of the application with different ports/configurations, so this isn't a critical issue that needs addressing.
  This comment should be deleted as it's asking for verification without identifying a clear problem that needs fixing.

4. aw_watcher_afk/afk.py:93

• Draft comment:
  Minor typographical inconsistency: The log message at line 93 uses 'afkwatcher' while the class is named 'AFKWatcher'. Consider aligning the naming for clarity.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_sFjoWfJSU1BcuATc

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

Consider using Python’s built-in getpass.getuser() for retrieving the current user, which is more cross‑platform and avoids using shell=True with subprocess.

Suggested change

	user = subprocess.check_output("who | awk '{print $1}' | head -n 1", shell=True).decode().strip()
	user = getpass.getuser()

[ErikBjare]

Did you mean to submit this upstream?

It will probably break the web UI, which expects the bucket name to start with aw-watcher-afk (iirc). Better to use a unique hostname per user (and ideally also a unique device_id for the bucket).