Skip to content

Minor improvements to benchmark/docker.sh #3999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Minor improvements to benchmark/docker.sh #3999

wants to merge 1 commit into from

Conversation

tarruda
Copy link

@tarruda tarruda commented May 11, 2025

  • Remove hardcoded "bash" command and use "$@" which will allow the caller to execute custom commands. If nothing is passed, then docker will fallback to bash anyway.
  • Forward the OPENAI_API_BASE env var.

@tarruda
Minor improvements to benchmark/docker.sh
cfab33f 
- Remove hardcoded "bash" command and use "$@" which will allow the caller to execute custom commands. If nothing is passed, then docker will fallback to bash anyway.
- Forward the `OPENAI_API_BASE` env var.
@tarruda tarruda mentioned this pull request May 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tarruda @paul-gauthier