-
Notifications
You must be signed in to change notification settings - Fork 9
Make SweepFormula a bit faster #2444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
t-b
wants to merge
13
commits into
main
Choose a base branch
from
bugfix/2444-faster-sweepformula
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function BSP_GetDevice is called quite often so let's do the expensive part only when locking the databrowser.
This makes it faster.
This is expensive
This makes DB_SplitSweepsIfReq faster as we only need to fetch the device once.
This is cheaper as we don't have to figure out the sweep datafolder.
This can not be triggered.
It is not possible to store invalid wave references in the cache. Although this can be useful to distinguish no cache entry from a cache entry without contents. We also tweaked the statistics output that this only outputs size zero for really empty waves and otherwise rounds up to 1MiB.
f548dce
to
5f92b8e
Compare
5f92b8e
to
4e5038c
Compare
We now store the fetched epochs in the cache and also the ones we filtered for short names and treelevel.
We now split all sweeps when locking the databrowser. New sweeps are already split on saving, see SWS_SaveAcquiredData. This makes SweepFormula faster as it does not need to care about sweep splitting anymore.
4e5038c
to
974fb20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here the SF code
with 66 sweeps got here 40%.
Close #2351
Close #2398