Skip to content

Store hide state of windows #2449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 21, 2025

Conversation

t-b
Copy link
Collaborator

@t-b t-b commented Jun 11, 2025

Close #1767

@t-b t-b force-pushed the feature/2449-store-hide-state-in-json-configuration branch from 179d63b to 862154c Compare June 11, 2025 19:53
@t-b t-b assigned t-b and unassigned timjarsky Jun 12, 2025
@t-b t-b force-pushed the feature/2449-store-hide-state-in-json-configuration branch 2 times, most recently from 9caf356 to 7703125 Compare June 25, 2025 07:32
@t-b t-b assigned timjarsky and unassigned t-b Jun 25, 2025
t-b added 5 commits June 30, 2025 23:20
In a future commit we want to add support for restoring the hidden state
of windows and subwindows.

For that to work we need to show the button to restore dynamically as we
can't rely on all windows being shown when the configuration is finished.
Move them into a subfolder and use the correct file ending as these are
JSON files.
As we are iterating over all subwindows, we need to continue. Bug present
since 645624a (Generic GUI Window Load/Save to Configuration File, 2019-12-12).
We now store the hide state of the window in the JSON object "Window
Properties". We also support old JSON files without that.

On restore we then apply the stored hide state.
@t-b t-b force-pushed the feature/2449-store-hide-state-in-json-configuration branch from 7703125 to d25ccce Compare June 30, 2025 21:21
@timjarsky
Copy link
Collaborator

@t-b IVSCC users will find this helpful. Thank you.

@timjarsky timjarsky assigned t-b and unassigned timjarsky Jul 21, 2025
@t-b t-b merged commit 5be611c into main Jul 21, 2025
19 checks passed
@t-b t-b deleted the feature/2449-store-hide-state-in-json-configuration branch July 21, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON Configuration: Does not remember hidden subwindows with the databrowser/sweepbrowser
2 participants