Various databrowser fixes: Overlay channels and non-splitted TTL #2454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-b
force-pushed
the
bugfix/2454-databrowser-unassoc-ttl
branch
from
a60df15 to
e731f0b
Compare
This is easier to grasp when it is at the start of the loop.
This allows to have a control disabled from multiple other controls.
… display We don't support that in LayoutGraph and we also don't need that combination. While at it we also disable splitTTL for overlay channels as that is ignored anyway.
For non-split TTL data the guiChannelNumber is NaN as we merge multiple TTL channels into own (ITC only). For the GetHeadstageColor function we now can't pass in NaN as the GUIchannelNumber but instead define a running ttlNumber which passes in the i-th active TTL channel.
t-b
force-pushed
the
bugfix/2454-databrowser-unassoc-ttl
branch
from
e731f0b to
6524264
Compare
timjarsky
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1813
Close #1787