This repository was archived by the owner on Apr 13, 2022. It is now read-only.
Support php 8 #25
Open
Support php 8 #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamCampbell Do you think you would be able to merge this pull request? |
|
This would be really handy if it was merged into the main branch. |
|
@GrahamCampbell Can you please review this PR? |
|
Merge it please! |
|
Repository is clearly abandoned. I suggest you create your own fork with this pull request (as I have) |
|
Just did it yes.. sad :( |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally Segment SDK supports PHP 8, so I updated this package to support it as well.