Skip to content

New contributions #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: 1.4
Choose a base branch
from
Open

New contributions #166

wants to merge 8 commits into from

Conversation

florintanasa
Copy link
Contributor

Hi,
I add some modification.

Also, I start a new project using this time Void Linux.
At this moment, only for Romanian language
https://github.com/florintanasa/brgvos-void

Florin Tanasa and others added 8 commits July 24, 2025 13:15
Reorders the compile command to ensure the linker flags are applied correctly.

This resolves an issue where the deskmon program would not compile due to missing linker flags.
Adds a configuration option to enable translation of the weather data obtained from the OpenWeatherMap API.
This improves the user experience by presenting weather information in the user's preferred language.
Configures templates for different languages.

Introduces language-specific template directories and default Markdown files within /etc/skel.
Ensures GTK 4.0 config is refreshed by removing the existing config and creating symlinks to the selected theme upon theme switch.
This guarantees immediate visual updates of GTK applications - libadwaita theme
Extends Latin & Cyrillic font support to include Romanian.
This ensures proper font rendering for Romanian language
content.
Adds the `printer-driver-all` package to the list of packages
installed by the script, providing better printer compatibility.
Installs the correct `libfuse` version based on the
`TARGET_UBUNTU_VERSION`. This ensures compatibility with different
Ubuntu releases.
Copy link
Owner

@Anduin2017 Anduin2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly awesome! But need further disuccsion. Thanks for the contribution!

cat << 'EOF' > /etc/skel/$TEMPLATE_DIR/Markdown.md
# Titlu

- [ ] De realizat 1
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This affects globally?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, only when is build for Romanian language.

@@ -85,8 +99,12 @@ export default class LightDarkSwitcherExtension extends Extension {
_syncTheme() {
let scheme = this._interfaceSettings.get_string('color-scheme');
if (scheme === DARK_SCHEME_NAME) {
GLib.spawn_async(null, ['sh', '-c', "rm -rf $HOME/.config/gtk-4.0/*"], null, GLib.SpawnFlags.SEARCH_PATH, null);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's that for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For theme, when change the theme to fix for libadawaita. In void linux I add also links in skel to work from the first boot look https://github.com/florintanasa/brgvos-void/tree/main/includedir/etc/skel/.config/gtk-4.0 I use for default the light theme.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at https://git.aiursoft.cn/PublicVault/Fluent-gtk-theme/src/branch/master/install.sh from line 718 when install the theme for libadwaita is necessary some links.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And depend on color theme, so when we change from dark to light is necessary some links to light theme and when we change from light to dark theme is necessary to change the links to dark.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, but exist some problem with links Gnome settings not appear correctly for Aspect page, look at color accent
with_links_in_config_gtk-4
but without links is not colored in red, the close button from upper right corner of the windows
with_no_links_in_config_gtk-4

Also, I comment the lines for icon theme, I installed Accent Icons extensions and I set this extension with all Fluent icons color, but not exist for teal, is necessary to request from developer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshots are taken from BRGV-OS based by Void Linux.

@@ -1,7 +1,7 @@
// ====================
// File: deskmon.c
// Daemon: watch ~/Desktop for new .desktop files, chmod +x and mark as trusted
// Compile: gcc `pkg-config --cflags --libs gio-2.0 glib-2.0` -O2 -o deskmon deskmon.c
// Compile: gcc `pkg-config --cflags gio-2.0 glib-2.0` -O2 -o deskmon deskmon.c `pkg-config --libs gio-2.0 glib-2.0`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's that for?

@@ -174,7 +174,7 @@ judge "Install gnome printer support"

print_ok "Installing ubuntu drivers support..."
apt install $INTERACTIVE \
ubuntu-drivers-common alsa-utils alsa-base fprintd --no-install-recommends
ubuntu-drivers-common alsa-utils alsa-base fprintd printer-driver-all --no-install-recommends
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have concern installing almost all drivers by default. Since not all users may need to setup a printer and this may cause the image larger. But I'm still wondering if it's a big issue that requires installing printer drivers manually.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, how you wish. But I prefer the user to have access to all drivers is easier for him and also if users see their printer from beginning is more happy.

libopengl0 \
initramfs-tools \
--no-install-recommends
judge "Install basic system tool packages"

print_ok "Installing libfuse for specific release..."
case $TARGET_UBUNTU_VERSION in
"questing")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's not needed because 1.4 branch is for questing while 1.3 is for plucky. But nice to have.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants