Skip to content

[2.0.0-dev] Protocol feature: packed_transaction_restrictions #1668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: release/2.0
Choose a base branch
from
Open

[2.0.0-dev] Protocol feature: packed_transaction_restrictions #1668

wants to merge 17 commits into from

Conversation

heifner
Copy link
Member

@heifner heifner commented Jul 1, 2025

  • Adds protocol feature: PACKED_TRANSACTION_RESTRICTIONS.
    • Enforces no extra-data in packed_transaction in blocks
    • Enforces no compressed packed_transaction in blocks
  • Subjectively enforces no extra-data in packed_transaction via P2P and API.
  • Subjectively normalizes all packed_transaction to non-compressed for transfer on P2P and in blocks.

Resolves #1472

heifner added 14 commits June 25, 2025 11:33
@heifner
GH-1472 Remove unused get_raw_transaction()
297a4af
@heifner
GH-1472 Initial impl of packed_transaction enforcement of extra data …
ed68490 
…and no compression
@heifner
Merge remote-tracking branch 'spring/release/2.0' into GH-1472-packed…
ed1e992 
…-trx-2.0
@heifner
GH-1472 Do not use zlib for random tests as zlib.
6cb66dd
@heifner
GH-1472 Update for new protocol feature
4829545
@heifner
GH-1472 work around GH-1666
1fe808e
@heifner
GH-1472 Use correct hash
fc03024
@heifner
GH-1472 Update test
8933263
@heifner
GH-1472 Update for updated protocol digest
38ab9c7
@heifner
GH-1472 Work around issue 1666
aadff5d
@heifner
GH-1472 start on protocol test for packed transaction restrictions
91c17d1
@heifner
GH-1472 Test extra data and compressed trxs in blocks not allowed aft…
e15834c 
…er packed_transaction_restrictions protocol feature activated
@heifner
GH-1472 Enforce no extra-data and no compression in transaction_conte…
6fc1ac6 
…xt for produced/validated blocks
@heifner
GH-1472 Enforce no extra-data and no compression in transaction_conte…
b2937c9 
…xt for produced/validated blocks
@heifner heifner added consensus-protocol Change to the consensus protocol. Impacts light client validation. OCI Work exclusive to OCI team labels Jul 1, 2025
@heifner heifner linked an issue Jul 1, 2025 that may be closed by this pull request
Protocol Feature: Disallow extra data in packed_transaction and eliminate compression from transaction receipt commitments #1472
Open
heifner
heifner commented Jul 1, 2025
View reviewed changes
unittests/blocks_log_replay_tests.cpp Outdated
blockslog.seek_end(0);
size_t size = blockslog.tellp();
blockslog.seek(size/2);
blockslog.seek(pos+20);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #1666

heifner
heifner commented Jul 1, 2025
View reviewed changes
heifner
heifner commented Jul 1, 2025
View reviewed changes
greg7mdp
greg7mdp approved these changes Jul 1, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
consensus-protocol Change to the consensus protocol. Impacts light client validation. OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Protocol Feature: Disallow extra data in packed_transaction and eliminate compression from transaction receipt commitments
2 participants
@heifner @greg7mdp