Skip to content

Should not announce hints multiple times by default #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Should not announce hints multiple times by default #116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Archipelago.MultiClient.Net/Helpers/LocationCheckHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,7 @@ public void ScoutLocationsAsync(Action<Dictionary<long, ScoutedItemInfo>> callba
/// <inheritdoc/>
public void ScoutLocationsAsync(Action<Dictionary<long, ScoutedItemInfo>> callback = null, bool createAsHint = false, params long[] ids) =>
// Maintain backwards compatibility if createAsHint parameter is not specified.
ScoutLocationsAsync(callback, createAsHint ? HintCreationPolicy.CreateAndAnnounce : HintCreationPolicy.None, ids);
ScoutLocationsAsync(callback, createAsHint ? HintCreationPolicy.CreateAndAnnounceOnce : HintCreationPolicy.None, ids);

/// <inheritdoc/>
public void ScoutLocationsAsync(Action<Dictionary<long, ScoutedItemInfo>> callback = null, params long[] ids) =>
Expand Down Expand Up @@ -480,7 +480,7 @@ public Task<Dictionary<long, ScoutedItemInfo>> ScoutLocationsAsync(HintCreationP

/// <inheritdoc/>
public Task<Dictionary<long, ScoutedItemInfo>> ScoutLocationsAsync(bool createAsHint, params long[] ids) =>
ScoutLocationsAsync(createAsHint ? HintCreationPolicy.CreateAndAnnounce : HintCreationPolicy.None, ids);
ScoutLocationsAsync(createAsHint ? HintCreationPolicy.CreateAndAnnounceOnce : HintCreationPolicy.None, ids);

/// <inheritdoc/>
public Task<Dictionary<long, ScoutedItemInfo>> ScoutLocationsAsync(params long[] ids) =>
Expand Down