AHIT: Fix death link timestamps being incorrect #5404
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
|
Would it work to abort that message and use send_death() instead? |
I could, but what would the difference be? |
ScipioWright
added
is: bug/fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Fixes the death link timestamps sent from A Hat in Time using an incorrect time, causing some games to not react to the death link.
This is something that has to be fixed in the Python client and not the mod because the timestamp functions in UnrealScript are evidently broken. So the fix here is to just update the time value in the death link packet before it gets sent.
How was this tested?
Connecting to a slot with death link enabled, triggering a death link, and then printing the death link packet.
If this makes graphical changes, please attach screenshots.