wip mavlink2rest support #215
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IamPete1
reviewed
Nov 11, 2024
| @@ -115,6 +271,17 @@ function setup_connect(button_svg, button_color) { | |||
| } | |||
|
|
|||
| ws.onmessage = (msg) => { | |||
| if (msg.data[0] == "{") { | |||
There was a problem hiding this comment.
I think you should just be able to check if its a string. Presuming that the json data is sent as a text message and that raw is sent with the binary message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to get this stuff out onto a separate file, but I'm opening the pr so I don't forget about it.
I already works as is. With BlueOS, I use
ws://192.168.2.2/mavlink2rest/ws/mavlinkfor connecting.This just maps the msg object format from mavlink2rest`s to the one outputted by the js parser.