Skip to content

Conversation

AlwinGarside
Copy link
Collaborator

@AlwinGarside AlwinGarside commented Oct 28, 2024

This PR contains the changes suggested by @visualight in #145.

@AlwinGarside AlwinGarside linked an issue Oct 28, 2024 that may be closed by this pull request
Copy link
Contributor

@gcphost gcphost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are failing as well

// COMMIT : force delete when parent model "isForceDeleting = true"
if ($this->isForceDeleting($relation)) {
$relationModel->forceDelete();
} else {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return early instead of else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ForceDelete functionality added
2 participants