Skip to content

Modified for custom DropDown Height #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Modified for custom DropDown Height #306

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 42 additions & 9 deletions DropDown/src/DropDown.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,16 @@ public final class DropDown: UIView {
public var width: CGFloat? {
didSet { setNeedsUpdateConstraints() }
}


/* changes for custom height */
/**
The height of the drop down.
*/
public var height: CGFloat? {
didSet { setNeedsUpdateConstraints() }
}
/* end changes */

/**
arrowIndication.x

Expand Down Expand Up @@ -578,8 +587,20 @@ extension DropDown {
xConstraint.constant = layout.x
yConstraint.constant = layout.y
widthConstraint.constant = layout.width
heightConstraint.constant = layout.visibleHeight


/* changes for custom height */
// heightConstraint.constant = layout.visibleHeight
if let height = self.height {
if layout.visibleHeight >= height {
heightConstraint.constant = self.height ?? layout.visibleHeight
} else {
heightConstraint.constant = layout.visibleHeight
}
} else {
heightConstraint.constant = layout.visibleHeight
}
/* end changes */

tableView.isScrollEnabled = layout.offscreenHeight > 0

DispatchQueue.main.async { [weak self] in
Expand Down Expand Up @@ -750,12 +771,24 @@ extension DropDown {
var y = (anchorViewMaxY + topOffset.y) - tableHeight

let windowY = window.bounds.minY + DPDConstant.UI.HeightPadding

if y < windowY {
offscreenHeight = abs(y - windowY)
y = windowY
}


/* changes for custom height */
/*
if y < windowY {
offscreenHeight = abs(y - windowY)
y = windowY
}
*/
if y < windowY {
offscreenHeight = abs(y - windowY)
if let height = self.height {
y = anchorViewMaxY + topOffset.y - height
} else {
y = windowY
}
}
/* end changes */

let width = self.width ?? (anchorView?.plainView.bounds.width ?? fittingWidth()) - topOffset.x

return (x, y, width, offscreenHeight)
Expand Down