Skip to content

Add a link to some more guidelines for good commit messages #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add a link to some more guidelines for good commit messages #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion day2_software/prs_and_reviewing.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,8 @@
"\n",
"**Bad commit message:** ``Fixed stuff. It's Friday evening and I want to go home now``\n",
"\n",
"If you have a few minutes to spare, [here are some more guidelines for good commit messages (and why they matter)](https://chris.beams.io/posts/git-commit/).\n",
"\n",
"You can now check that your commit is in the history using:\n",
"\n",
" git log\n",
Expand Down Expand Up @@ -219,7 +221,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.7.4"
"version": "3.7.1"
}
},
"nbformat": 4,
Expand Down