Make Configure Asset Panel Reactive [AARD-2074]
#1272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rutmanz
requested review from
azaleacolburn,
Dhruv-0-Arora,
PepperLola and
BrandonPacewic
AlexD717
approved these changes
Aug 14, 2025
fission/src/ui/panels/configuring/assembly-config/configure/AssemblySelection.tsx
Outdated
Show resolved
Hide resolved
…semblySelection.tsx Co-authored-by: Alexey Dmitriev <[email protected]>
Co-authored-by: Alexey Dmitriev <[email protected]>
azaleacolburn
approved these changes
Aug 20, 2025
BrandonPacewic
approved these changes
Aug 21, 2025
Draft
|
Workflows are taking an exceptionally long time to run currently. Going to start queing up pull requests to be merged. This pull request is at the front of the que. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
AARD-2074
Symptom
Identified when testing multiplayer, adding or removing assets not from within the panel (i.e. the context menu) while the configure asset panel is open does not update the list of assets
Solution
Made it react to mirabuf creation and configuration events
Verification
Open configure assets and spawn assets at the same time (until the UI refactor fixes branch is merged, then just spawn and then open the configure assets panel), spawn a robot, configure it, remove it via the context menu, and observe that the state of the configure assets panel is accurate the whole time
Before merging, ensure the following criteria are met: