-
Notifications
You must be signed in to change notification settings - Fork 61
Refactor Mirabuf Loading System [AARD-2060]
#1273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rutmanz
wants to merge
16
commits into
dev
Choose a base branch
from
zachr/2060/mirabuf-refactor
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azaleacolburn
approved these changes
Aug 14, 2025
5 tasks
Chorus detected one or more security issues with this pull request. See the Checks tab for more details. As a reminder, please follow the secure code review process as part of the Secure Coding Non-Negotiable requirement. |
edf84e2
to
91d228d
Compare
fix: try to make unit tests work fix: actually make unit tests work feat: add unit tests for default assets fix: tsconfig issues again
91d228d
to
edee81d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
AARD-2060 - Refactor mirabuf caching service
AARD-2069 - Make uploading local mirabuf files enforce correct miratype (with gamepieces we can't just infer miratype completely)
Symptom
The current MirabufCachingService made a few decisions that made it hard to understand and had some key limitations:
id
field was unique but not consistent (it was based on the time that you first downloaded the file to your cache). This was the impetus for changing this, as we needed consistent IDs for multiplayer.cacheKey
field was either the name of the APS project, the remote download URL, or the hash of the locally uploaded fileMirabufCacheInfo
type was used both to store information about the OPFS files and to store in-memory references to the ArrayBuffersSolution
id
field has been replaced with ahash
field, that is the SHA-1 hash of the assembly (consistent and unique)name
), and there is a single source of truth for asset metadataVerification
Note
Your mirabuf cache will be cleared every time you switch between Synthesis on this branch and Synthesis not on this branch
Before merging, ensure the following criteria are met: