-
Notifications
You must be signed in to change notification settings - Fork 2k
MSD: Add app-level site settings configuration (2nd try) #106682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested v1, /v2, and /ciab. Works 👍
| <SectionHeader title={ __( 'General' ) } level={ 3 } /> | ||
| <SummaryButtonList> | ||
| <SiteVisibilitySettingsSummary site={ site } /> | ||
| { supportsSettings.general.redirect ? ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v1 works as expected 👍
A follow-up of #106667.
Proposed Changes
As discussed in p1761133256103549-slack-C09JEQLTH8R, we want to remove some site settings for CIAB. That is, to just keep Site Visibility setting, and the Danger Zone.
The previous PR was reverted since it broken the Site Settings backport due to the lack of app-level configuration.
Why are these changes being made?
CIAB-MSD
Testing Instructions
Pre-merge Checklist