Skip to content

Conversation

@taipeicoder
Copy link
Contributor

@taipeicoder taipeicoder commented Oct 23, 2025

A follow-up of #106667.

Proposed Changes

As discussed in p1761133256103549-slack-C09JEQLTH8R, we want to remove some site settings for CIAB. That is, to just keep Site Visibility setting, and the Danger Zone.

image

The previous PR was reverted since it broken the Site Settings backport due to the lack of app-level configuration.

Why are these changes being made?

CIAB-MSD

Testing Instructions

  • Head to /v2
  • Select a site and click on the Settings tab
  • Ensure that it works as before, and every button navigates to the expected screen
  • Head to /ciab
  • Select a site and click on the Settings tab
  • Ensure that it only displays the expected settings, and every button navigates to the expected screen
  • Head to /sites (v1)
  • Select a site and click on the Settings tab
  • Ensure that it works as before, and every button navigates to the expected screen

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@taipeicoder taipeicoder self-assigned this Oct 23, 2025
@github-actions
Copy link

github-actions bot commented Oct 23, 2025

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/msd-app-level-site-settings-config on your sandbox.

@taipeicoder taipeicoder marked this pull request as ready for review October 23, 2025 13:17
@taipeicoder taipeicoder requested a review from a team as a code owner October 23, 2025 13:17
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 23, 2025
Copy link
Contributor

@fushar fushar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested v1, /v2, and /ciab. Works 👍

<SectionHeader title={ __( 'General' ) } level={ 3 } />
<SummaryButtonList>
<SiteVisibilitySettingsSummary site={ site } />
{ supportsSettings.general.redirect ? (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Copy link
Contributor

@arthur791004 arthur791004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1 works as expected 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants