Add 'innererror' property bag to CloudError contract #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jianghaolu
reviewed
Jan 10, 2018
| /** | ||
| * The inner error. | ||
| */ | ||
| private ObjectNode innererror; |
There was a problem hiding this comment.
What's the format of the innerError? Will it be a HashMap? (judging on your test)
Also please camel case the variables and methods.
There was a problem hiding this comment.
It will be an arbitrary JSON struct with an object at the top level. Inside could be multiple levels of nesting, arrays and numbers.
|
Looks like all of the issues have been addressed. Is there anything else that needs to be changed? |
|
@demyanenko based on the discussion with .net runtime team, our understanding is - shape of innerError is not yet finialized with ARM team. \cc @shahabhijeet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The data contract for ARM errors includes
innererrorfield which is a property bag with unspecified contents as per OData 4.0 spec. This field wasn't used by ARM up until now, but recently there was a change related to Azure Policy that makes heavy use of this property bag. It is already deployed in all regions and consumed by Azure Portal, so now would be a good time to support it in SDKs as well.The new errors are generated by the ARM Frontdoor itself, so CloudError seems like the most appropriate contract to include it.